Skip to content

fix(): combine release workflow#28

Merged
kwong0222 merged 2 commits intomainfrom
fix/kwong0222/combine-release-workflow
Dec 11, 2024
Merged

fix(): combine release workflow#28
kwong0222 merged 2 commits intomainfrom
fix/kwong0222/combine-release-workflow

Conversation

@kwong0222
Copy link
Copy Markdown
Contributor

@kwong0222 kwong0222 commented Dec 11, 2024

This PR:

  • Fixes issue when a new tag is pushed and the release docker build workflow is not run.

Github Actions do not trigger other workflows when ${{secrets.GITHUB_TOKEN}} is used in the workflow. As the checkout action implicitly uses this secret in the release.yml workflow, it will not trigger the docker-release.yml workflow on push. This did work in the past as a tag was created...

@github-actions
Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
src
   exceptions.py40100% 
   main.py871616 82%
src/clients/github
   graphql.py4022 95%
   queries.py20100% 
src/clients/slack
   client.py2333 87%
tests
   __init__.py00100% 
   conftest.py00100% 
   test_main.py570100% 
tests/clients/github
   test_github_graphql.py410100% 
tests/clients/slack
   test_slack.py370100% 
TOTAL2912193% 

Tests Skipped Failures Errors Time
24 0 💤 0 ❌ 0 🔥 0.419s ⏱️

@kwong0222 kwong0222 marked this pull request as ready for review December 11, 2024 18:28
@kwong0222 kwong0222 requested a review from a team as a code owner December 11, 2024 18:28
@kwong0222 kwong0222 merged commit 73d9b98 into main Dec 11, 2024
@kwong0222 kwong0222 deleted the fix/kwong0222/combine-release-workflow branch December 11, 2024 18:30
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.1.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants