COO-760: fix: allow to create a logging plugin without a loki stack #743
Conversation
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
|
@jgbernalp: This pull request references COO-760 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
* fix: further fix github action olm publish failure (#742) * fix: allow to create a logging plugin without a loki stack (#743) Signed-off-by: Gabriel Bernal <gbernal@redhat.com> * build: check for go installation before setting up a new environment (#745) Signed-off-by: Gabriel Bernal <gbernal@redhat.com> * feat: enable deployment of common accelerator perses dashboard (#744) Common accelerator perses dashboard contains metrics that are common for different accelerators' vendors. The dashboard will be deployed along with UI plugin * fix: Update main.go korrel8r tag to release-coo-1.2 (#746) * feat: add monitoring-plugin stream 0.4 and 0.5 (#747) Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com> * feat: add CRD scaffolding for cluster observability / signal manager (#748) Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * chore: update troubleshooting plugin image tag (#749) Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com> * fix: add default value to logs schema (#751) * fix: check lokistack value on lokistack discovery (#753) Signed-off-by: Gabriel Bernal <gbernal@redhat.com> * chore: update troubleshooting plugin to new image (#755) * chore: update logging image to v6.1.1 (#756) * chore(release): 1.2.0 (new cut) --------- Signed-off-by: Gabriel Bernal <gbernal@redhat.com> Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com> Signed-off-by: Pavol Loffay <p.loffay@gmail.com> Co-authored-by: lihongyan1 <hongyli@redhat.com> Co-authored-by: Gabriel Bernal <gbernal@redhat.com> Co-authored-by: Yevgeny Shnaidman <60741237+yevgeny-shnaidman@users.noreply.github.com> Co-authored-by: Alan Conway <aconway@redhat.com> Co-authored-by: Jenny Zhu <jenny.a.zhu@gmail.com> Co-authored-by: Pavol Loffay <p.loffay@gmail.com>
Use a default name to allow to create the logging plugin even if no loki stacks can be discovered in the cluster.