COO-760: fix: check LokiStack value on discovery #753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
jgbernalp
requested review from
danielmellado and
JoaoBraveCoding
and removed request for
a team
|
@jgbernalp: This pull request references COO-760 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot bot
pushed a commit
that referenced
this pull request
May 28, 2025
* fix: further fix github action olm publish failure (#742) * fix: allow to create a logging plugin without a loki stack (#743) Signed-off-by: Gabriel Bernal <gbernal@redhat.com> * build: check for go installation before setting up a new environment (#745) Signed-off-by: Gabriel Bernal <gbernal@redhat.com> * feat: enable deployment of common accelerator perses dashboard (#744) Common accelerator perses dashboard contains metrics that are common for different accelerators' vendors. The dashboard will be deployed along with UI plugin * fix: Update main.go korrel8r tag to release-coo-1.2 (#746) * feat: add monitoring-plugin stream 0.4 and 0.5 (#747) Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com> * feat: add CRD scaffolding for cluster observability / signal manager (#748) Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * chore: update troubleshooting plugin image tag (#749) Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com> * fix: add default value to logs schema (#751) * fix: check lokistack value on lokistack discovery (#753) Signed-off-by: Gabriel Bernal <gbernal@redhat.com> * chore: update troubleshooting plugin to new image (#755) * chore: update logging image to v6.1.1 (#756) * chore(release): 1.2.0 (new cut) --------- Signed-off-by: Gabriel Bernal <gbernal@redhat.com> Signed-off-by: Jenny Zhu <jenny.a.zhu@gmail.com> Signed-off-by: Pavol Loffay <p.loffay@gmail.com> Co-authored-by: lihongyan1 <hongyli@redhat.com> Co-authored-by: Gabriel Bernal <gbernal@redhat.com> Co-authored-by: Yevgeny Shnaidman <60741237+yevgeny-shnaidman@users.noreply.github.com> Co-authored-by: Alan Conway <aconway@redhat.com> Co-authored-by: Jenny Zhu <jenny.a.zhu@gmail.com> Co-authored-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.