Shade json-simple for JVM agent jar#413
Merged
Merged
Conversation
The dependency is then included in its own namespace, namely org.jolokia.shaded.org.json.simple*. Closes jolokia#398
jerboaa
force-pushed
the
jvm_agent_shade
branch
from
bf6088d to
e7ab408
Compare
rhuss
approved these changes
Oct 11, 2019
Member
rhuss
left a comment
rhuss
left a comment
There was a problem hiding this comment.
Thanks ! The changes makes a lot of sense. Let me integrate over the next week.
Contributor
Author
|
Thanks for the review! |
|
Any update on this, we are waiting for this to be merged and released so we can utilize both json-simple and jolokia via the same Classpath. |
|
Hello, any updates on this? We're also waiting for it. Thanks. |
Member
|
sorry, I'm late with this. Let me have a look over the weekend. Apologies for the delay ... |
Member
|
Thanks, looks good to me ! Let's put it into a Jolokia 1.4.0, hopefully to be released soonish. |
|
Thank you @rhuss ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency is then included in its own namespace,
namely org.jolokia.shaded.org.json.simple*.
Closes #398