/var/www/html nuke may be overkill

[jnovack]

This makes it EXTREMELY hard to pre-populate the /var/www/html/ directory with volumes...

https://github.com/ngineered/nginx-php-fpm/blob/master/scripts/start.sh#L40

start.sh

   # Remove the test index file
   rm -Rf /var/www/html/*

I can't docker volume in any files (like a config.php) or any directories into /var/www/html/.

I would humbly propose rm -Rf /var/www/html/index.php.

[Coffee2CodeNL]

I'd rather like to see an environment variable (USE_GIT)

[richarvey]

@isdp i like that idea if I set up USE_GIT=1 as default and nothing changes in the script but if you set USE_GIT=0 we dont

   # Remove the test index file
   rm -Rf /var/www/html/*

Do you think thats a good course of action?

[Coffee2CodeNL]

Sounds fine to me :)

[richarvey]

New flag will be REMOVE_FILES=0

[Coffee2CodeNL]

Rather hoped for the ability to completely shut off the Git functionality.

It's really annoying to have to make a gazillion commits to update the files on my server properly =[

[jnovack]

@richarvey Excellent, thank you!

And I kinda agree with @isdp @isdp Are you just mounting in your /var/www/html, if so, this command neither helps nor hurts because the conditional isn't running.

If you are talking about developing within the container, then you'll definitely WANT to use a mount. Edit locally, refresh in container. But to stop it from removing the /var/www/html/* files, just make a directory called /.git, or don't use GIT_REPO. Either one of those will prevent the conditional from running.

[Coffee2CodeNL]

@jnovack what if you want to track your code in git but don't want the container to do it's git stuff then?

Explicit defining is always better than implicitly through a folder's existence.

[jnovack]

what if you want to track your code in git but don't want the container to do it's git stuff then?

Mount the git-versioned source directory on your host as /var/www/html read-only and DO NOT set any GIT variables. The start.sh script finds the /var/www/html/.git/ directory, and does nothing else.

If you aren't doing the above (heretoforth called Use Case 1), and your aren't letting the container do it's "git stuff" (heretoforth called Use Case 2), then by all accounts, "you are doing it wrong(tm)".