Skip to content

fix(ConferenceCall,CallCtrlPage): fix the issue about conference call dialer page doesn't handle mergingPair correctly #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2018
Merged

fix(ConferenceCall,CallCtrlPage): fix the issue about conference call dialer page doesn't handle mergingPair correctly #1142

merged 2 commits into from
Aug 29, 2018

Conversation

@kafka-yu
Copy link
Contributor

@kafka-yu kafka-yu commented Aug 29, 2018 •
edited
Loading

  • Change the /conferencecall/dialer router template from "/conferenceCall/dialer/:fromNumber" to
    path="/conferenceCall/dialer/:fromNumber/:fromSessionId"
  • refine the way to call setMergingPair, only at call button clicked

#RCINT-8432

@kafka-yu kafka-yu requested a review from huanhulan August 29, 2018 01:19
@kafka-yu kafka-yu changed the title fix(8432): fix the issue about conference call dialer page doesn't handle mergingPair correctly fix(ConferenceCall,CallCtrlPage): fix the issue about conference call dialer page doesn't handle mergingPair correctly Aug 29, 2018
Rukai Yu added 2 commits August 29, 2018 10:10
@kafka-yu kafka-yu merged commit ee91bde into ringcentral:master Aug 29, 2018
@kafka-yu kafka-yu deleted the RCINT-8432 branch August 29, 2018 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@huanhulan huanhulan huanhulan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kafka-yu @huanhulan