add active call control module #1143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this module designed for |
|
This is a module for active call control for ringout |
huanhulan
suggested changes
Aug 29, 2018
packages/ringcentral-integration/modules/ActiveCallControl/getDataReducer.js
Show resolved
Hide resolved
unadlib
approved these changes
Aug 29, 2018
huanhulan
reviewed
Aug 30, 2018
| sessionId | ||
| }); | ||
| } | ||
| case types.startRecord: { |
There was a problem hiding this comment.
may be consider merge this case with the following case, since all the procedures are the same except the isRecorded
| isToVoicemail: false, | ||
| lastHoldingTime: 0, | ||
| minimized: false, | ||
| recordStatus: isRecorded ? recordStatus.recording : recordStatus.idle, |
There was a problem hiding this comment.
do u think isOnRecording is a better name for the situation?
| () => this.activeSessionsStatus, | ||
| (calls, activeSessionsStatus) => { | ||
| const _activeSessions = {}; | ||
| calls.forEach((call) => { |
There was a problem hiding this comment.
reduce() it, and by using rambda
…s into active-call-control-module # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
huanhulan
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.