fix(IncomingCallPage, ActiveCallsPage): 🐛 fix a bug that the mergingPair is not removed when the inbound call is answered #1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kafka-yu
commented
Sep 27, 2018
kafka-yu
commented
- Add logic to remove the mergingPair when answer the incoming call in IncomingCallPage and ActiveCallsPage
ruleechen
approved these changes
Sep 27, 2018
ruleechen
suggested changes
Sep 27, 2018
packages/ringcentral-widgets/containers/ActiveCallsPage/index.js
Outdated
Show resolved
Hide resolved
kafka-yu
force-pushed
the
RCINT-8751
branch
from
e776af5 to
240666e
Compare
huanhulan
approved these changes
Sep 27, 2018
ruleechen
approved these changes
Sep 27, 2018
added 4 commits
September 27, 2018 15:02
…r is not removed when the inbound call is answered
kafka-yu
force-pushed
the
RCINT-8751
branch
from
240666e to
64b17c4
Compare
sophiewu2333
pushed a commit
to sophiewu2333/ringcentral-js-widgets
that referenced
this pull request
Sep 28, 2018
…air is not removed when the inbound call is answered (ringcentral#1312) * chore(CallMonitor): cleanup code * fix(App): enable cache in getAvatarUrl call function * fix(IncomingCallPage, ActiveCallsPage): fix a bug that the mergingPair is not removed when the inbound call is answered * chore(ActiveCallsPage): cleanup code review comments
sophiewu2333
added a commit
that referenced
this pull request
Sep 28, 2018
…air is not removed when the inbound call is answered (#1312) (#1334) * chore(CallMonitor): cleanup code * fix(App): enable cache in getAvatarUrl call function * fix(IncomingCallPage, ActiveCallsPage): fix a bug that the mergingPair is not removed when the inbound call is answered * chore(ActiveCallsPage): cleanup code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.