feat(CallLogger): Support transferred call #1388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuluxmu
reviewed
Oct 18, 2018
| if (presenceRegExp.test(message.event) && message.body) { | ||
| if (message.body.sequence) { | ||
| if (message.body.sequence <= this._lastSequence) { | ||
| if (message.body.sequence < this._lastSequence) { |
There was a problem hiding this comment.
I think when we remove '=', we need to consider if it has any impact for call secenario.
I think QAs need to do call scenario tests as many as possible.
tuluxmu
reviewed
Oct 18, 2018
| this._lastProcessedCalls = null; | ||
| this._lastProcessedEndedCalls = null; | ||
| this._customMatcherHooks = []; | ||
| this._transferredCallsMap = {}; |
There was a problem hiding this comment.
There is a scenario we need to think of:
- refresh the page
tuluxmu
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.