feat: support fax on message page #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringcentral#809) * fix bug Click back button in compose text should navigate to message list * add settimeout to goback function * when click goback in conversationpanel should navigate to message text list * when click goback in conversationpanel should navigate to message text list
* feature/messages-fax messages * update action button ui when offlinee * update messageStore to set filter the sendingfailed and queued messges by messagestatus * update preview button's tooltip to View * update unit test according to the changes * change from allconversations to conversations * change from allconversations to conversations * change from allconversations to conversations * add faxpermissions to hasreadmessagespermission * add integration test * add integration test for fax * update integration test * bugfix/6658 Fax icon display incorrectly in call history tab * update integration test
* implements start google hangouts with conference * remove comments in googleHangouts module * update mainview * update google hangouts * update if statements
embbnux
reviewed
Mar 3, 2018
| import i18n from './i18n'; | ||
|
|
||
| function ConfirmDeleteModal({ | ||
| export function ConfirmDeleteModal({ |
There was a problem hiding this comment.
used in tests, can be separated into independent files when needed
embbnux
approved these changes
Mar 3, 2018
|
Build successful! You can check your changes here: https://ec2-52-17-190-173.eu-west-1.compute.amazonaws.com/job/rc-js-widget-pr/56/ |
* fix bug X button disappears * set regex as const value * update ui of hangup button * fix bug that notification not disappear * use onblur to control isfocusoninput * add timeout * set timeout as 0 * set timeout
|
Build successful! You can check your changes here: https://ec2-52-17-190-173.eu-west-1.compute.amazonaws.com/job/rc-js-widget-pr/60/ |
embbnux
pushed a commit
to embbnux/ringcentral-js-widget
that referenced
this pull request
Apr 25, 2018
* fix bug Click back button in compose text should navigate to message … (ringcentral#809) * fix bug Click back button in compose text should navigate to message list * add settimeout to goback function * when click goback in conversationpanel should navigate to message text list * when click goback in conversationpanel should navigate to message text list * Feature/messages fax (ringcentral#778) * feature/messages-fax messages * update action button ui when offlinee * update messageStore to set filter the sendingfailed and queued messges by messagestatus * update preview button's tooltip to View * update unit test according to the changes * change from allconversations to conversations * change from allconversations to conversations * change from allconversations to conversations * add faxpermissions to hasreadmessagespermission * add integration test * add integration test for fax * update integration test * bugfix/6658 Fax icon display incorrectly in call history tab * update integration test * replace keypad icon to make stroke-line fillable (ringcentral#820) * implements start google hangouts with conference (ringcentral#819) * implements start google hangouts with conference * remove comments in googleHangouts module * update mainview * update google hangouts * update if statements * fix bug X button disappears (ringcentral#766) * fix bug X button disappears * set regex as const value * update ui of hangup button * fix bug that notification not disappear * use onblur to control isfocusoninput * add timeout * set timeout as 0 * set timeout * fix lint issue * upgrade commons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.