Enhance/shared babel #738
Merged
Enhance/shared babel #738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ele828
reviewed
May 8, 2018
.babelrc
Outdated
| "transform-decorators-legacy" | ||
| "transform-function-bind", // stage 0 | ||
| "transform-export-extensions", // stage 1 | ||
| "transform-class-properties" // stage 2 |
There was a problem hiding this comment.
Would you also consider extending babelrc from babel-settings?
ele828
reviewed
May 8, 2018
packages/monorepo-tools/package.json
Outdated
| "scripts": {}, | ||
| "dependencies": { | ||
| "@yarnpkg/lockfile": "^1.0.0", | ||
| "babel-settings": "0.0.1", |
There was a problem hiding this comment.
babel-settings is more complicated, babel-runtime is a runtime dependency rather than a dev dependency.
There was a problem hiding this comment.
hmm... good point though.. let me reconsider this.
ele828
reviewed
May 8, 2018
package.json
Outdated
| "list-file-matchers": "babel-node scripts/listFileMatchers.js" | ||
| }, | ||
| "dependencies": { | ||
| "babel-settings": "0.0.1" |
ele828
approved these changes
May 8, 2018
embbnux
reviewed
May 8, 2018
| "eslint-plugin-import": "^2.8.0", | ||
| "eslint-plugin-jsx-a11y": "^6.0.2", | ||
| "eslint-plugin-react": "^7.5.1", | ||
| "eslint-settings": "0.0.1", |
There was a problem hiding this comment.
Does this make yarn install broken?
There was a problem hiding this comment.
Don't think so. I've done a git clean -xdf to clear out all the files to do a clean install. Plus all the CI tests passed, so the installation should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.