fix(rcint-8093):show phone numbers in E.164 #944
Conversation
| name: lastCall.to.phoneNumber, | ||
| name: null, | ||
| status: lastCall.webphoneSession ? lastCall.webphoneSession.callStatus : null, | ||
| phoneNumber: lastCall.to.phoneNumber |
There was a problem hiding this comment.
for the sake of performance, plz make sure that one and only one shape is given to the value of the _lastCallInfo
| status: lastCall.webphoneSession.callStatus, | ||
| }; | ||
| } else if (lastCalleeType === calleeTypes.unknow) { | ||
| _lastCallInfo = { |
There was a problem hiding this comment.
switch...case
since the condition only change by the value of lastCalleeType
| </div> | ||
| <div className={styles.callee_name}> | ||
| { | ||
| (lastCallInfo.calleeType === calleeTypes.conference) |
There was a problem hiding this comment.
(lastCallInfo.calleeType === calleeTypes.conference)
you have already did this as the isOnConferenCall
| </div> | ||
| ); | ||
|
|
||
| const currentCallTitle = nameMatches.length |
There was a problem hiding this comment.
what if nameMatches is not a array?
| color: #303030; | ||
| float: left; | ||
| max-width: 43%; | ||
| max-width: 58%; |
There was a problem hiding this comment.
as long as we fix the width of the avatar and the call status, then we don't need this 58%, let flex layout to do the job
| phoneNumber: lastCall.to.phoneNumber, | ||
| extraNum: 0, | ||
| }; | ||
| } |
There was a problem hiding this comment.
return the value inside the case... directly, since this function is all about the_lastCallInfo
There was a problem hiding this comment.
Omit it, since we need to update the mutable data _lastCallInfo
2 participants
No description provided.