fix(WebPhone, ActiveCallPanel): fix blank page #952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging an onhold active call on merge control page, the old logic will preserve the active session id as the cached call's id, we need to update it when clear the caching. BREAKING CHANGE: add sessions into clearSessionCaching() and add `clearSessionCaching` action into getActiveSessionIdReducer()
huanhulan
force-pushed
the
fixOnholdBlankPage
branch
from
248f10a to
8036994
Compare
filter out the cached sessions
ruleechen
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging an onhold active call on merge control page, the old logic will preserve the active
session id as the cached call's id, we need to update it when clear the caching.
BREAKING CHANGE: add sessions into clearSessionCaching() and add
clearSessionCachingaction intogetActiveSessionIdReducer()