feat(Conference, Webphone): RCINT-7871:Cannot add people to call while the call is being recorded #968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modify mockApi to specify http method name * disable log btn in call list when the item is fax messsage (ringcentral#775) * disable log btn in call list when the item is fax messsage * should show button on call log notification when have related function * Fix mock API for meeting scheduler (ringcentral#777) * Mock Meeting & Service Info api (ringcentral#779) * mock API * no message * change switch disable color (ringcentral#778) * change switch disable color * remove setting page last two item line border (ringcentral#782) * remove setting page last two item line border * [feature] Wrap libphonenumber-js in @ringcentral-integration/phone-number package (ringcentral#783) * fix linkline icon postion to alignment right (ringcentral#784) * fix linkline icon postion to alignment right * modify logout icon size * Modify style of log icon in calls tab (ringcentral#785) * Modify style of log icon * fix dialerUI hooks sync (ringcentral#786) * Rcint 7530 audio setting messy code (ringcentral#781) * fix messy code showed when device is plugged out * code refine * update * update * fix failed tests in LogBasicInfo which is caused by letter case mismatch (ringcentral#789) * Update the style and text of DatePicker. (ringcentral#792) * fix search input exceeding width issue (ringcentral#791) * bugfix: user guide module cannot fall back to en-US automatically (ringcentral#787) * minor: make close button optional in AdpterCore (ringcentral#788) * fix SpinnerOverlay background-color translucence bug for safari (ringcentral#794) * fix tests in LogBasicInfo which is caused by letter case mismatch (ringcentral#793)
…s into rcint-7871
ruleechen
approved these changes
Aug 1, 2018
ruleechen
approved these changes
Aug 1, 2018
…s into rcint-7871
huanhulan
suggested changes
Aug 1, 2018
| isRecording(session) { | ||
| const isRecordStart = status => ( | ||
| status === recordStatus.pending || | ||
| status === recordStatus.recording |
There was a problem hiding this comment.
why not just !==recordStatus.idle
There was a problem hiding this comment.
and why create a calculus every time we run theisRecording
There was a problem hiding this comment.
and why add this function into the conference call module?
| } | ||
| } | ||
|
|
||
| isRecording(status) { |
There was a problem hiding this comment.
remove this to webphoneHelper.js
huanhulan
approved these changes
Aug 2, 2018
huanhulan
changed the title
huanhulan
changed the title
huanhulan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature(rcint-7871): Improvement_User cannot add people to call while the call is being recorded