Change InsideModal according to recently modification on Modal #992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-widgets into feature/user-permission
…s-widgets into feature/user-permission
…allenger/ringcentral-js-widgets into feature/user-permission
…allenger/ringcentral-js-widgets into feature/user-permission
…allenger/ringcentral-js-widgets into feature/user-permission
…s-widgets into feature/user-permission
Hazyzh
reviewed
Aug 2, 2018
| import classnames from 'classnames'; | ||
| import Modal from '../Modal'; | ||
| import styles from './styles.scss'; | ||
| import InsideModalClose from '../../assets/images/InsideModalClose.svg'; |
There was a problem hiding this comment.
Seems like can remove this line at the same time.
huanhulan
approved these changes
Aug 2, 2018
| show={show} | ||
| showCloseBtn={showCloseBtn} | ||
| onCancel={onClose} | ||
| > |
There was a problem hiding this comment.
how about add aclickOutToClose props?
There was a problem hiding this comment.
It's cool! Done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloseButtoninInsideModal, as it's not needed inModal.showCloseBtnandonCancelprops according toModalprop types.showCloseBtnprop inInsideModal, it's default value is true.So the modal can be closed.