This repository was archived by the owner on Jan 9, 2024. It is now read-only.
Resolve leaking error message #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
alexstoick
force-pushed
the
fix/resolve-error-objects-leaking-state
branch
3 times, most recently
from
5d7367c to
515b7aa
Compare
The race condition in the Snowflake code allows the overwriting of the error message. The fix removes the shared variable and thus avoid cases where `err.Error()` changes partway through execution.
alexstoick
force-pushed
the
fix/resolve-error-objects-leaking-state
branch
from
515b7aa to
294be98
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The race condition in the Snowflake code allows the overwriting of the
error message. The fix removes the shared variable and thus avoid cases
where
err.Error()changes partway through execution.