This repository was archived by the owner on Jan 9, 2024. It is now read-only.
Do not use rb_raise to gen exception from Go
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This interacts weirdly with the GoGC and the Go control mechanism, as this pushes the return value of a _Go_ function to a _C_ object. This trips up the Go Gargabe collector. I have **not** removed all usages of `rb_raise` for now, just in this `Fetch` method, renamed it to `_fetch` and wrapped it in a `fetch` method and doing the exception raising from the Ruby code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interacts weirdly with the GoGC and the Go control mechanism, as
this pushes the return value of a Go function to a C object. This
trips up the Go Gargabe collector.
I have not removed all usages of
rb_raisefor now, just in thisFetchmethod, renamed it to_fetchand wrapped it in afetchmethod and doing the exception raising from the Ruby code.