fix(image): Fixed default return bug in image embed and remove dead code

Author: ritz078

Gruntfile.js

@@ -29,11 +29,11 @@ module.exports = function(grunt) {
             },
             css: {
                 files: ['src/css/**/*.scss'],
-                tasks: ['sass']
+                tasks: ['sass','postcss']
             },
             js: {
                 files: ['src/js/**/*.es6','build.json'],
-                tasks: ['webpack:build-dev']
+                tasks: ['webpack:build-dev','uglify']
             }
         },
 

dist/embed.min.js

@@ -1,6 +1,6 @@
 const utils = require('../utils.es6');
 
-// if(build.SOUNDCLOUD) var SoundCloud = require('./soundcloud.es6');
+if(build.SOUNDCLOUD) var SoundCloud = require('./soundcloud.es6');
 if(build.SPOTIFY)    var Spotify    = require('./spotify.es6');
 if(build.BASICAUDIO) var BasicAudio = require('./basic.es6');
 
@@ -17,7 +17,7 @@ class Audio{
 			let output = this.output;
 			let embeds = this.embeds;
 			console.log(output, embeds);
-			// embeds = utils.ifEmbed(this.options, 'soundcloud') && build.SOUNDCLOUD ? (new SoundCloud(this.input, this.options, embeds).process()) : embeds;
+			embeds = utils.ifEmbed(this.options, 'soundcloud') && build.SOUNDCLOUD ? (new SoundCloud(this.input, this.options, embeds).process()) : embeds;
 			embeds = utils.ifEmbed(this.options, 'spotify') && build.SPOTIFY ? (new Spotify(this.input, this.options, embeds).process()) : embeds;
 			embeds = this.options.audioEmbed && build.BASICAUDIO ? (new BasicAudio(this.input, this.options, embeds).process()) : embeds;
 

src/embed.js

@@ -17,9 +17,9 @@ class Image{
 			let input  = this.input;
             let output = this.output;
             let embeds = this.embeds;
-            embeds = utils.ifEmbed(this.options, 'flickr') && build.FLICKR ? (new Flickr(input, this.options, embeds).process()) : output;
-            embeds = utils.ifEmbed(this.options, 'instagram') && build.INSTAGRAM ? (new Instagram(input, this.options, embeds).process()) : output;
-            embeds = this.options.imageEmbed && build.BASICIMAGE ? (new Basic(input, this.options, embeds).process()) : output;
+            embeds = utils.ifEmbed(this.options, 'flickr') && build.FLICKR ? (new Flickr(input, this.options, embeds).process()) : embeds;
+            embeds = utils.ifEmbed(this.options, 'instagram') && build.INSTAGRAM ? (new Instagram(input, this.options, embeds).process()) : embeds;
+            embeds = this.options.imageEmbed && build.BASICIMAGE ? (new Basic(input, this.options, embeds).process()) : embeds;
 
             return [output, embeds];
 		}catch(error){

src/embed.js.map

@@ -30,6 +30,16 @@ module.exports = {
             'fetchJsonp': 'fetch-jsonp'
                     }),
         new webpack.optimize.DedupePlugin(),
+        new webpack.optimize.UglifyJsPlugin({
+            compress:{
+                warnings:false
+            },
+            mangle:false,
+            output:{
+                beautify:true,
+                comments:true
+            }
+        })
         ],
     stats: {
         // Nice colored output