Skip to content

Commit a72784d

Browse files
ritz078ritz078
committed
feat(opengraph): Integrated opengraph support with inline embedding.
fixes #82
1 parent eea4d12 commit a72784d

9 files changed

Lines changed: 10 additions & 15 deletions

File tree

‎demo/index.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@
3131
<body>
3232

3333
<h1>Loading embed.js in a block</h1>
34-
<div id="url">
35-
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Itaque consectetur iure culpa reiciendis repudiandae vitae quae temporibus eum fugit, porro accusamus https://vimeo.com/119199079 quis quas sapiente, deleniti! Suscipit excepturi ipsa nobis corrupti.
34+
<div id="url" class="block">
35+
Lorem ipsum dolor sit amet, consectetur adipisicing elit. Itaque consectetur iure culpa reiciendis repudiandae vitae quae temporibus eum fugit, porro accusamus https://vimeo.com/119199079 quis quas sapiente, deleniti! Suscipit excepturi ipsa nobis corrupti.
3636
</div>
3737
<div id="block">
3838

‎dist/embed.min.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/embed.min.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/css/embed.scss‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ code {
239239
background-size: cover;
240240
background-position: center;
241241
display: inline-block;
242-
background-color: $primary;
242+
background-color: $border-color;
243243
}
244244

245245
.ejs-ogp-details {

‎src/embed.css‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/embed.css.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/embed.js‎

Lines changed: 1 addition & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/embed.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/js/modules/openGraph.es6‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,11 @@ export default class OpenGraph {
2626
try {
2727
url = encodeURIComponent(url);
2828
let api = new Function('url', 'return `' + this.options.openGraphEndpoint + '`')(url);
29-
let response = await fetch(api, {
30-
credentials: 'no-cors'
31-
});
29+
let response = await fetch(api);
3230
let data = await response.json();
3331
return this.options.onOpenGraphFetch(data) || data
3432
} catch (e) {
3533
this.options.onOpenGraphFail(e);
36-
3734
}
3835
}
3936

0 commit comments

Comments
 (0)