Skip to content

Commit b2d6a00

Browse files
ritz078ritz078
committed
fix(gist): Fixed inline embedding of github gist
1 parent 99cb21f commit b2d6a00

5 files changed

Lines changed: 15 additions & 11 deletions

File tree

‎dist/embed.min.js‎

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/embed.js‎

Lines changed: 5 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/embed.js.map‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/js/embed.es6‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,13 +172,13 @@ const helper = require('./modules/video/helper.es6');
172172
let result = await this.process();
173173
this.options.element.innerHTML = result;
174174

175-
let event = new Event('rendered');
176-
this.options.element.dispatchEvent(event);
177-
178175
helper.applyVideoJS(this.options);
179176

180177
helper.play('ejs-video-thumb', this.options);
181178

179+
let event = new Event('rendered');
180+
this.options.element.dispatchEvent(event);
181+
182182
this.options.afterEmbedJSApply();
183183
}
184184

‎src/js/modules/code/gist.es6‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,10 @@ class Gist extends Base {
2929
zone.appendChild(gistFrame);
3030

3131
// Create the iframe's document
32+
let url = gists[i].getAttribute('data-src')
33+
url = url.indexOf('http') === -1 ? `https://${url}`: url
3234
var gistFrameHTML =
33-
`<html><base target="_parent"/><body onload="parent.document.getElementById('ejs-gist-${i}').style.height=parseInt(document.body.scrollHeight)+20+'px'"><script type="text/javascript" src="https://${gists[i].getAttribute('data-src')}.js"></script></body></html>`;
35+
`<html><base target="_parent"/><body onload="parent.document.getElementById('ejs-gist-${i}').style.height=parseInt(document.body.scrollHeight)+20+'px'"><script type="text/javascript" src="${url}.js"></script></body></html>`;
3436

3537
// Set iframe's document with a trigger for this document to adjust the height
3638
var gistFrameDoc = gistFrame.document;

0 commit comments

Comments
 (0)