Skip to content

Commit c4e865c

Browse files
committed
fix(opengraph): fixed opengraph error
1 parent 2caca5e commit c4e865c

7 files changed

Lines changed: 19 additions & 18 deletions

File tree

dist/embed.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/embed.es2015.js

Lines changed: 4 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/embed.es2015.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/embed.js

Lines changed: 6 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/embed.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/js/main.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { ifEmbed, createText, deepExtend, cloneObject, processOptions } from './modules/utils'
1+
import {ifEmbed, createText, deepExtend, cloneObject, processOptions} from './modules/utils'
22

33
import Renderer from './modules/template'
44

@@ -23,7 +23,7 @@ import Github from './modules/github'
2323

2424
import regex from './modules/regex'
2525

26-
import { applyVideoJS, playVideo, destroyVideos, baseEmbed } from './helpers'
26+
import {applyVideoJS, playVideo, destroyVideos, baseEmbed} from './helpers'
2727

2828
var globalOptions = {};
2929

@@ -66,6 +66,7 @@ var defaultOptions = {
6666
videoWidth : null,
6767
videoDetails : true,
6868
audioEmbed : true,
69+
imageEmbed : true,
6970
excludeEmbed : [],
7071
inlineEmbed : [],
7172
inlineText : true,

src/js/modules/openGraph.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,17 +28,15 @@ export default class OpenGraph {
2828
}
2929

3030
static urlToText(_, match, url) {
31-
if (!url.match(_.excludeRegex)) return;
31+
if (url.match(_.excludeRegex)) return Promise.resolve();
3232

3333
return new Promise((resolve) => {
34-
OpenGraph.fetchData(url, _).then((data) => resolve(data && data.success ? _.template(data) : null))
34+
OpenGraph.fetchData(url, _).then((data) => resolve(data && data.success ? _.template(data) : ''))
3535
})
3636
}
3737

3838

3939
process() {
40-
return new Promise(function (resolve) {
41-
asyncEmbed(this, OpenGraph.urlToText).then((data) => resolve(data))
42-
})
40+
return new Promise((resolve) => asyncEmbed(this, OpenGraph.urlToText).then((data) => resolve(data)))
4341
}
4442
}

0 commit comments

Comments
 (0)