Skip to content

Commit e19068b

Browse files
committed
fix(destroy): fixed .load of undefined when tweetsEmbed was turned off.
1 parent 274dc9f commit e19068b

6 files changed

Lines changed: 8 additions & 6 deletions

File tree

β€Ždist/embed.min.jsβ€Ž

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žsrc/embed.es2015.jsβ€Ž

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žsrc/embed.es2015.js.mapβ€Ž

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žsrc/embed.jsβ€Ž

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žsrc/embed.js.mapβ€Ž

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

β€Žsrc/js/main.jsβ€Ž

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,8 @@ export default class EmbedJS {
343343
destroy() {
344344
if (typeof this.options.input !== 'object') throw new Error(`destroy() method only works if an element had been passed in the options object`);
345345
destroyVideos('ejs-video-thumb');
346-
this.options.input.removeEventListener('rendered', this.twitter.load(), false);
346+
if (this.options.tweetsEmbed)
347+
this.options.input.removeEventListener('rendered', this.twitter.load(), false);
347348
this.options.input.innerHTML = this.input
348349
}
349350

0 commit comments

Comments
Β (0)