Skip to content

chore(cloud): update default version format to not use special characters #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024
Merged

chore(cloud): update default version format to not use special characters #1003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions svc/pkg/cloud/worker/src/workers/version_name_reserve.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,19 @@ async fn worker(

// Generate date
//
// Use UTC in order to ensure that the month is consistent if a team is collaborating from
// multiple locations around the world with different time zones
// Use UTC to ensure consistency across different time zones
let now = chrono::Utc::now();
let date_prefix = now.format("%Y.%m").to_string();
let date_prefix = now.format("%Y.%m.%d").to_string();

let (display_name,) = sql_fetch_one!(
[ctx, (String,)]
r#"
WITH next_version AS (
-- Increment the highest existing number by 1, or start with 1 if none exist
SELECT $2 || ' (' || (COALESCE(MAX(SUBSTRING(version_display_name FROM $2 || ' \((\d+)\)')::INT), 0) + 1) || ')' AS new_version
SELECT $2 || '-' || (COALESCE(MAX(SUBSTRING(version_display_name FROM $2 || '-(\d+)')::INT), 0) + 1)::TEXT AS new_version
FROM db_cloud.game_version_name_reservations
-- Filter for rows with the matching game ID and version format
WHERE version_display_name ~ $2 || ' \(\d+\)'
WHERE version_display_name ~ $2 || '-\d+'
AND game_id = $1
)
-- Insert the new version name into the table
Expand All @@ -47,3 +46,4 @@ async fn worker(

Ok(())
}