Skip to content

fix(workflows): fix loops queries #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix(workflows): fix loops queries #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions lib/chirp-workflow/core/src/db/pg_nats.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -951,47 +951,53 @@ impl Database for DatabasePgNats {
SET forgotten = TRUE
WHERE
workflow_id = $1 AND
loop_location = $2
loop_location = $2 AND
forgotten = FALSE
RETURNING 1
),
forget_signal_events AS (
UPDATE db_workflow.workflow_signal_events
SET forgotten = TRUE
WHERE
workflow_id = $1 AND
loop_location = $2
loop_location = $2 AND
forgotten = FALSE
RETURNING 1
),
forget_sub_workflow_events AS (
UPDATE db_workflow.workflow_sub_workflow_events
SET forgotten = TRUE
WHERE
workflow_id = $1 AND
loop_location = $2
loop_location = $2 AND
forgotten = FALSE
RETURNING 1
),
forget_signal_send_events AS (
UPDATE db_workflow.workflow_signal_send_events
SET forgotten = TRUE
WHERE
workflow_id = $1 AND
loop_location = $2
loop_location = $2 AND
forgotten = FALSE
RETURNING 1
),
forget_message_send_events AS (
UPDATE db_workflow.workflow_message_send_events
SET forgotten = TRUE
WHERE
workflow_id = $1 AND
loop_location = $2
loop_location = $2 AND
forgotten = FALSE
RETURNING 1
),
forget_loop_events AS (
UPDATE db_workflow.workflow_loop_events
SET forgotten = TRUE
WHERE
workflow_id = $1 AND
loop_location = $2
loop_location = $2 AND
forgotten = FALSE
RETURNING 1
)
SELECT 1
Expand Down
Empty file added svc/pkg/workflow/db/workflow/migrations/20240809230231_fix_loop_idx.down.sql
View file
Open in desktop
Empty file.
30 changes: 30 additions & 0 deletions svc/pkg/workflow/db/workflow/migrations/20240809230231_fix_loop_idx.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
CREATE INDEX idx_workflow_loop_events_loop_location2
ON workflow_loop_events (workflow_id, loop_location)
WHERE forgotten = FALSE;

CREATE INDEX idx_workflow_activity_events_loop_location2
ON workflow_activity_events (workflow_id, loop_location)
WHERE forgotten = FALSE;

CREATE INDEX idx_workflow_signal_events_loop_location2
ON workflow_signal_events (workflow_id, loop_location)
WHERE forgotten = FALSE;

CREATE INDEX idx_workflow_sub_workflow_events_loop_location2
ON workflow_sub_workflow_events (workflow_id, loop_location)
WHERE forgotten = FALSE;

CREATE INDEX idx_workflow_signal_send_events_loop_location2
ON workflow_signal_send_events (workflow_id, loop_location)
WHERE forgotten = FALSE;

CREATE INDEX idx_workflow_message_send_events_loop_location2
ON workflow_message_send_events (workflow_id, loop_location)
WHERE forgotten = FALSE;

DROP INDEX workflow_loop_events@idx_workflow_loop_events_loop_location;
DROP INDEX workflow_activity_events@idx_workflow_activity_events_loop_location;
DROP INDEX workflow_signal_events@idx_workflow_signal_events_loop_location;
DROP INDEX workflow_sub_workflow_events@idx_workflow_sub_workflow_events_loop_location;
DROP INDEX workflow_signal_send_events@idx_workflow_signal_send_events_loop_location;
DROP INDEX workflow_message_send_events@idx_workflow_message_send_events_loop_location;