fix: container runner logs not working #2152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Deploying rivet with
|
| Latest commit: |
5358edc
|
| Status: | 🚫 Build failed. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes container runner logging by renaming the Vector message source from "actor" to "actors" for consistency, but introduces critical compilation errors.
- Mismatched enum variant usage in
/packages/edge/infra/client/container-runner/src/log_shipper.rs-VectorMessage::Actorneeds to be updated toVectorMessage::Actors - Similar variant mismatch in
/packages/core/infra/legacy/job-runner/src/log_shipper.rs- code uses oldActorvariant instead of newActors - Serde rename attribute updated from "actor" to "actors" but implementation code not aligned
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
NathanFlurry
force-pushed
the
03-07-fix_container_runner_logs_not_working
branch
from
f563e78 to
5358edc
Compare
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RVT-4664