chore: switch to building toolchain with dockerfiles instead of github actions #2407
Conversation
NathanFlurry
force-pushed
the
04-26-chore_switch_to_building_toolchain_with_dockerfiles_instead_of_github_actions
branch
from
3b900eb to
8b9d863
Compare
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR moves the Rivet CLI build process from GitHub Actions to Dockerfiles, implementing a more standardized cross-compilation toolchain for multiple platforms and architectures.
- Added platform-specific Dockerfiles in
/docker/toolchain/for Linux, macOS, and Windows builds with proper cross-compilation setup - Introduced
/scripts/toolchain/build-cross.shto orchestrate cross-compilation builds with improved platform/architecture handling - Modified
.github/workflows/release.yamlto use the new Docker-based build system with simplified matrix configuration - Configured proper static linking with OpenSSL for Linux builds and osxcross for macOS cross-compilation
- Implemented build caching using Docker mount points for cargo registry and git dependencies
9 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| RUN wget https://www.openssl.org/source/openssl-$SSL_VER.tar.gz \ | ||
| && tar -xzf openssl-$SSL_VER.tar.gz \ | ||
| && cd openssl-$SSL_VER \ | ||
| && ./Configure no-shared no-async --prefix=/musl-aarch64 --openssldir=/musl-aarch64/ssl linux-aarch64 \ |
There was a problem hiding this comment.
style: Consider adding no-deprecated flag to OpenSSL Configure to reduce binary size and remove deprecated functions
| # Skip aws-lc-rs with rustls certs config when building for macOS | ||
| RUSTFLAGS="--cfg tokio_unstable --cfg rustls_native_certs --cfg aws_lc_rs" \ | ||
| CARGO_FEATURE_RUSTLS_NATIVE_CERTS=0 \ |
There was a problem hiding this comment.
logic: Setting both rustls_native_certs flag and CARGO_FEATURE_RUSTLS_NATIVE_CERTS=0 seems contradictory. Verify this configuration is intentional.
| #!/bin/bash | ||
| set -e |
There was a problem hiding this comment.
style: Consider adding -u flag to fail on unset variables
| #!/bin/bash | |
| set -e | |
| #!/bin/bash | |
| set -eu |
NathanFlurry
force-pushed
the
04-26-chore_switch_to_building_toolchain_with_dockerfiles_instead_of_github_actions
branch
from
8b9d863 to
4a72647
Compare
Deploying rivet with
|
| Latest commit: |
4a72647
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://942b0594.rivet.pages.dev |
| Branch Preview URL: | https://04-26-chore-switch-to-buildi.rivet.pages.dev |
NathanFlurry
changed the base branch from
04-26-chore_temporarily_disable_sentry
to
graphite-base/2407
|
See #2400 |
1 participant
Changes