-
Notifications
You must be signed in to change notification settings - Fork 139
chore: fill out remaining content for landing page #2413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fill out remaining content for landing page #2413
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Deploying rivet with
|
| Latest commit: |
163db63
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://accc4ba7.rivet.pages.dev |
| Branch Preview URL: | https://graphite-base-2441.rivet.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Based on the extensive changes in this PR, here's a focused summary of the key modifications:
Significant overhaul of the landing page and site infrastructure with removal of Framer-based components:
- Removed all CodeMirror language support files (20+ files) which could impact code editing capabilities across multiple languages
- Removed Framer-specific components and configurations including manifesto, pricing, and sales pages
- Migrated from
unframertoframer-motionfor animations in FancyHeader component
Key content and structural changes:
- Added new landing page content with clearer feature descriptions for Functions, Actors, and Containers
- Added new MarketingButton component for consistent CTA styling
- Added new comparison page placeholder for "Rivet vs Cloudflare Workers"
- Improved CopyCommand component accessibility with better button interaction
These changes suggest a major shift in the site's architecture and content strategy, but the removal of CodeMirror language support without clear replacements could impact code editing functionality.
58 file(s) reviewed, 20 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Removing this entire file will break code editing functionality including snippets, bracket matching, and autocompletion. Ensure this code has been moved elsewhere or these features are no longer needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Removing this file will break shell script syntax highlighting. Either keep the file or ensure its functionality is replaced by another module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: The entire Swift mode file has been removed. This will break Swift syntax highlighting functionality in the editor. Consider keeping this file unless there is a specific reason for its removal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: This file's removal will break type checking for ManifestoFramerComponent. The component is still used in ManifestoPage.tsx and needs these type definitions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Removing this file breaks TypeScript type definitions for PricingFramerComponent. Either restore this file or ensure types are defined elsewhere.
| }: { | ||
| children: React.ReactNode; | ||
| href: string; | ||
| primary?: boolean; | ||
| }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider defining a separate interface for the props to improve code organization and reusability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: The entire manifesto page component has been removed. If this was intentional, ensure there is a replacement component or that this functionality is no longer needed. If unintentional, this deletion should be reverted.
| <MarketingButton href="#deploy" primary> | ||
| Deploy Now | ||
| </MarketingButton> | ||
| <MarketingButton href="/rivet-vs-cloudflare-workers"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: The href '/rivet-vs-cloudflare-workers' should include '/docs' prefix to match the commented out version above
|
|
||
| <p className="text-white text-sm">{description}</p> | ||
|
|
||
| <p className="text-white text-sm text-white/40"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: Duplicate class 'text-white' in className string - one should be removed
| <p className="text-white text-sm text-white/40"> | |
| <p className="text-sm text-white/40"> |
| description: | ||
| "Run CPU- & memory-intensive workloads in secure containers with blazing fast coldstarts", | ||
| faIcon: faServer, | ||
| href: "/docs/stateful-jobs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: This href points to '/docs/stateful-jobs' but should likely be '/docs/containers' since it's for Sandboxed Containers
cd7fa2a to
9463d62
Compare
aad9b30 to
e299c37
Compare
Deploying rivet-hub with
|
| Latest commit: |
163db63
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9261af74.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://graphite-base-2441.rivet-hub-7jb.pages.dev |
e299c37 to
aad9b30
Compare
a3691d4 to
b07221a
Compare
aad9b30 to
4bd91aa
Compare
65c6194 to
bfd1247
Compare
4bd91aa to
b2d4a53
Compare
bfd1247 to
b2595f2
Compare
b2595f2 to
d4f2bbf
Compare
b2d4a53 to
5026b91
Compare
d4f2bbf to
05aaf76
Compare
5026b91 to
31cd9fd
Compare
c10da64 to
163db63
Compare
163db63 to
55eb392
Compare
Merge activity
|
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->

Changes