Skip to content

Conversation

@NathanFlurry
Copy link
Member

Changes

Copy link
Member Author

NathanFlurry commented Apr 30, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 30, 2025

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 163db63
Status: ✅  Deploy successful!
Preview URL: https://accc4ba7.rivet.pages.dev
Branch Preview URL: https://graphite-base-2441.rivet.pages.dev

View logs

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Based on the extensive changes in this PR, here's a focused summary of the key modifications:

Significant overhaul of the landing page and site infrastructure with removal of Framer-based components:

  • Removed all CodeMirror language support files (20+ files) which could impact code editing capabilities across multiple languages
  • Removed Framer-specific components and configurations including manifesto, pricing, and sales pages
  • Migrated from unframer to framer-motion for animations in FancyHeader component

Key content and structural changes:

  • Added new landing page content with clearer feature descriptions for Functions, Actors, and Containers
  • Added new MarketingButton component for consistent CTA styling
  • Added new comparison page placeholder for "Rivet vs Cloudflare Workers"
  • Improved CopyCommand component accessibility with better button interaction

These changes suggest a major shift in the site's architecture and content strategy, but the removal of CodeMirror language support without clear replacements could impact code editing functionality.

58 file(s) reviewed, 20 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Removing this entire file will break code editing functionality including snippets, bracket matching, and autocompletion. Ensure this code has been moved elsewhere or these features are no longer needed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Removing this file will break shell script syntax highlighting. Either keep the file or ensure its functionality is replaced by another module.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: The entire Swift mode file has been removed. This will break Swift syntax highlighting functionality in the editor. Consider keeping this file unless there is a specific reason for its removal.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: This file's removal will break type checking for ManifestoFramerComponent. The component is still used in ManifestoPage.tsx and needs these type definitions.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Removing this file breaks TypeScript type definitions for PricingFramerComponent. Either restore this file or ensure types are defined elsewhere.

Comment on lines +8 to +12
}: {
children: React.ReactNode;
href: string;
primary?: boolean;
}) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider defining a separate interface for the props to improve code organization and reusability

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: The entire manifesto page component has been removed. If this was intentional, ensure there is a replacement component or that this functionality is no longer needed. If unintentional, this deletion should be reverted.

<MarketingButton href="#deploy" primary>
Deploy Now
</MarketingButton>
<MarketingButton href="/rivet-vs-cloudflare-workers">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: The href '/rivet-vs-cloudflare-workers' should include '/docs' prefix to match the commented out version above


<p className="text-white text-sm">{description}</p>

<p className="text-white text-sm text-white/40">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Duplicate class 'text-white' in className string - one should be removed

Suggested change
<p className="text-white text-sm text-white/40">
<p className="text-sm text-white/40">

description:
"Run CPU- & memory-intensive workloads in secure containers with blazing fast coldstarts",
faIcon: faServer,
href: "/docs/stateful-jobs",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: This href points to '/docs/stateful-jobs' but should likely be '/docs/containers' since it's for Sandboxed Containers

@NicholasKissel NicholasKissel force-pushed the 04-29-chore_fill_out_remaining_content_for_landing_page branch from cd7fa2a to 9463d62 Compare April 30, 2025 19:43
@NicholasKissel NicholasKissel force-pushed the 04-25-chore_updated_graphics_for_new_landing_page branch from aad9b30 to e299c37 Compare April 30, 2025 19:43
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 30, 2025

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: 55eb392
Status:⚡️  Build in progress...

View logs

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 30, 2025

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 163db63
Status: ✅  Deploy successful!
Preview URL: https://9261af74.rivet-hub-7jb.pages.dev
Branch Preview URL: https://graphite-base-2441.rivet-hub-7jb.pages.dev

View logs

@NathanFlurry NathanFlurry force-pushed the 04-25-chore_updated_graphics_for_new_landing_page branch from e299c37 to aad9b30 Compare May 2, 2025 06:46
@NathanFlurry NathanFlurry force-pushed the 04-29-chore_fill_out_remaining_content_for_landing_page branch 2 times, most recently from a3691d4 to b07221a Compare May 5, 2025 23:22
@NathanFlurry NathanFlurry force-pushed the 04-25-chore_updated_graphics_for_new_landing_page branch from aad9b30 to 4bd91aa Compare May 5, 2025 23:22
@NathanFlurry NathanFlurry force-pushed the 04-29-chore_fill_out_remaining_content_for_landing_page branch 4 times, most recently from 65c6194 to bfd1247 Compare May 9, 2025 00:38
@NathanFlurry NathanFlurry force-pushed the 04-25-chore_updated_graphics_for_new_landing_page branch from 4bd91aa to b2d4a53 Compare May 13, 2025 05:57
@NathanFlurry NathanFlurry force-pushed the 04-29-chore_fill_out_remaining_content_for_landing_page branch from bfd1247 to b2595f2 Compare May 13, 2025 05:57
@NicholasKissel NicholasKissel force-pushed the 04-29-chore_fill_out_remaining_content_for_landing_page branch from b2595f2 to d4f2bbf Compare May 13, 2025 20:16
@NicholasKissel NicholasKissel force-pushed the 04-25-chore_updated_graphics_for_new_landing_page branch from b2d4a53 to 5026b91 Compare May 13, 2025 20:16
@NathanFlurry NathanFlurry force-pushed the 04-29-chore_fill_out_remaining_content_for_landing_page branch from d4f2bbf to 05aaf76 Compare May 19, 2025 17:14
@NathanFlurry NathanFlurry force-pushed the 04-25-chore_updated_graphics_for_new_landing_page branch from 5026b91 to 31cd9fd Compare May 19, 2025 17:14
@NathanFlurry NathanFlurry force-pushed the 04-29-chore_fill_out_remaining_content_for_landing_page branch 2 times, most recently from c10da64 to 163db63 Compare May 19, 2025 18:08
@NathanFlurry NathanFlurry force-pushed the 04-29-chore_fill_out_remaining_content_for_landing_page branch from 163db63 to 55eb392 Compare May 19, 2025 18:24
@graphite-app
Copy link
Contributor

graphite-app bot commented May 19, 2025

Merge activity

  • May 19, 2:25 PM EDT: NathanFlurry added this pull request to the Graphite merge queue.
  • May 19, 2:25 PM EDT: CI is running for this pull request on a draft pull request (#2449) due to your merge queue CI optimization settings.
  • May 19, 2:26 PM EDT: Merged by the Graphite merge queue via draft PR: #2449.

graphite-app bot pushed a commit that referenced this pull request May 19, 2025
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this May 19, 2025
@graphite-app graphite-app bot deleted the 04-29-chore_fill_out_remaining_content_for_landing_page branch May 19, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants