Skip to content

fix: fix client leaked pipes #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Parent: fix(container-runner): fix leaked pipes
wants to merge 1 commit into from
Closed

fix: fix client leaked pipes #2474

wants to merge 1 commit into from

Conversation

@MasterPtato
Copy link
Contributor

Changes

@MasterPtato MasterPtato requested a review from NathanFlurry May 26, 2025 20:23
@NathanFlurry NathanFlurry mentioned this pull request May 26, 2025
Closed
@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented May 26, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MasterPtato MasterPtato mentioned this pull request May 26, 2025
Closed
greptile-apps[bot]
greptile-apps bot reviewed May 26, 2025
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR addresses client pipe leaks by updating the nix crate dependency and improving pipe handling across the codebase.

  • Updated workspace-level nix dependency from v0.27 to v0.30 in /Cargo.toml for improved Unix system operations
  • Clarified pipe cleanup behavior in /packages/edge/infra/client/manager/src/runner.rs with RAII guarantees
  • Standardized nix dependency usage across packages by moving configuration to workspace level
  • Removed explicit feature flags for nix in /packages/edge/services/pegboard/Cargo.toml in favor of workspace defaults

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@cloudflare-workers-and-pages
Copy link

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 147d554
Status: ✅  Deploy successful!
Preview URL: https://03c8125d.rivet.pages.dev
Branch Preview URL: https://05-26-fix-fix-client-leaked.rivet.pages.dev

View logs

@MasterPtato MasterPtato mentioned this pull request May 26, 2025
Closed
@graphite-app
Copy link
Contributor

graphite-app bot commented May 26, 2025 •
edited
Loading

Merge activity

  • May 26, 10:42 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
  • May 26, 10:43 PM UTC: CI is running for this pull request on a draft pull request (#2476) due to your merge queue CI optimization settings.
  • May 26, 10:44 PM UTC: Merged by the Graphite merge queue via draft PR: #2476.

graphite-app bot pushed a commit that referenced this pull request May 26, 2025
@MasterPtato
fix: fix client leaked pipes (#2474)
39220d3 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@cloudflare-workers-and-pages
Copy link

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: 147d554
Status:⚡️  Build in progress...

View logs

@graphite-app graphite-app bot closed this May 26, 2025
@graphite-app graphite-app bot deleted the 05-26-fix_fix_client_leaked_pipes branch May 26, 2025 22:44
@github-actions github-actions bot mentioned this pull request May 26, 2025
Merged
This was referenced May 27, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanFlurry NathanFlurry Awaiting requested review from NathanFlurry

1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MasterPtato