Skip to content

fix(workflows): fix branch version bug #2475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(workflows): fix branch version bug #2475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10c0c47
chore(pegboard): replace computing image size manually with using tar…
NathanFlurry Jun 16, 2025
7179109
fix(workflows): fix branch version bug
MasterPtato May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/common/chirp-workflow/core/src/ctx/workflow.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ impl WorkflowCtx {

/// Creates a new workflow run with one more depth in the location.
/// - **Not to be used directly by workflow users. For implementation uses only.**
/// - **Remember to validate history after this branch is used.**
/// - **Remember to validate latent history after this branch is used.**
#[tracing::instrument(skip_all)]
pub(crate) async fn branch(&mut self) -> WorkflowResult<Self> {
self.custom_branch(self.input.clone(), self.version).await
Expand All @@ -400,7 +400,7 @@ impl WorkflowCtx {
.commit_workflow_branch_event(
self.workflow_id,
&location,
self.version,
version,
self.loop_location.as_ref(),
)
.await?;
Expand All @@ -409,6 +409,7 @@ impl WorkflowCtx {
Ok(self.branch_inner(input, version, location))
}

/// `custom_branch` with no history validation.
pub(crate) fn branch_inner(
&mut self,
input: Arc<Box<serde_json::value::RawValue>>,
Expand Down
Loading