Skip to content

chore(pegboard): add exit code log from container runner #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(pegboard): add exit code log from container runner #2477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/edge/infra/client/container-runner/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,17 @@ fn main() -> Result<()> {
&container_id,
root_user_enabled,
) {
Result::Ok(exit_code) => exit_code,
Result::Ok(exit_code) => {
eprintln!("run container exited: {exit_code}");
container::send_message(
&msg_tx,
None,
log_shipper::StreamType::StdErr,
format!("Exited with exit code {exit_code}"),
);
Comment on lines +71 to +76
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Consider using stdout instead of stderr for successful exit codes since this is expected behavior, not an error condition


exit_code
}
Err(err) => {
eprintln!("run container failed: {err:?}");
container::send_message(
Expand Down
Loading