Skip to content

refactor: replace unsafe File::from_raw_fd with safe File::from #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor: replace unsafe File::from_raw_fd with safe File::from #2479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/edge/infra/client/isolate-v8-runner/src/isolate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,10 +217,10 @@ pub async fn run_inner(
let (stderr_read_fd, stderr_write_fd) = pipe()?;

// SAFETY: These are created by pipes
let stdout_reader = unsafe { std::fs::File::from_raw_fd(stdout_read_fd) };
let stdout_writer = unsafe { std::fs::File::from_raw_fd(stdout_write_fd) };
let stderr_reader = unsafe { std::fs::File::from_raw_fd(stderr_read_fd) };
let stderr_writer = unsafe { std::fs::File::from_raw_fd(stderr_write_fd) };
let stdout_reader = std::fs::File::from(stdout_read_fd);
let stdout_writer = std::fs::File::from(stdout_write_fd);
let stderr_reader = std::fs::File::from(stderr_read_fd);
let stderr_writer = std::fs::File::from(stderr_write_fd);
let mut stderr_writer2 = stderr_writer.try_clone()?;

let isolate_stdout = BufReader::new(stdout_reader);
Expand Down
Loading