fix: change invalid atom value #2600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Restructures actor filter atom implementation to fix invalid atom value handling in the Jotai state management system.
- Modifies
actorsInternalFilterAtominfrontend/packages/components/src/actors/actor-context.tsxto store filter function in an object structure withfnproperty - Updates
frontend/apps/hub/src/domains/project/components/actors/actors-provider.tsxto properly wrap internal filter function in object format when setting atom value - Improves type safety and state handling for actor filtering logic in the Hub application
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Contributor
Graphite Automations"Test" took an action on this PR • (06/13/25)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes