Skip to content

fix: add cpu constraints to oci config #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Parent: fix: api changes
wants to merge 1 commit into from
Closed

fix: add cpu constraints to oci config #2697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions packages/edge/infra/client/manager/src/runner/oci_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ use std::path::Path;

use super::{partial_oci_config::PartialOciConfigUser, seccomp};

// CPU period in microseconds.
//
// https://www.kernel.org/doc/Documentation/scheduler/sched-bwc.txt
const CPU_PERIOD: u64 = 100000;

pub struct ConfigOpts<'a> {
pub runner_path: &'a Path,
pub netns_path: &'a Path,
Expand Down Expand Up @@ -89,14 +94,8 @@ pub fn config(opts: ConfigOpts) -> Result<serde_json::Value> {
// If `quota` is greater than `period`, it is allowed to use multiple cores.
//
// Read more: https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/6/html/resource_management_guide/sec-cpu
// "quota": CPU_PERIOD * cpu / 1_000,
// "period": CPU_PERIOD,
// Use the env var for the CPU since Nomad handles assigning CPUs to each task
// "cpus": if cpu >= 1_000 {
// Some(template_env_var("NOMAD_CPU_CORES"))
// } else {
// None
// }
"quota": CPU_PERIOD * opts.cpu / 1_000,
"period": CPU_PERIOD,
}))
} else {
None
Expand Down
Loading