feat(site): set user's email during newsletter form submission

[jog1t]

Changes

Added PostHog person property tracking for email addresses submitted through the newsletter form. When a user submits their email, we now set their email as a person property in PostHog, enabling better user identification and tracking.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rivet-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 28, 2025 7:03pm

[claude]

Claude finished @jog1t's task —— View job

---

PR Review Complete ✅

Reviewed the newsletter form enhancement that adds user email setting to PostHog analytics.

Review Tasks

• Read the changed Newsletter.tsx file to understand implementation
• Analyze code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Review security concerns
• Assess test coverage needs
• Provide comprehensive review feedback

---

📋 Review Feedback

✅ What's Working Well

• Clean integration with existing PostHog analytics
• Proper form submission handling with duplicate prevention
• Good user experience with submit state management

⚠️ Issues Found

1. Critical Bug - Line 14

const data = Object.fromEntries(formData.entries().toArray());

❌ Problem: FormData.entries() returns an iterator, not an object with a .toArray() method. This will cause a runtime error.

✅ Fix: Remove .toArray():

const data = Object.fromEntries(formData.entries());

2. Fragile Email Access - Lines 22

email: Object.values(data)[0],

❌ Problem: Using Object.values(data)[0] assumes the email is always the first form field. This is brittle and could break if form structure changes.

✅ Fix: Access email directly by field name:

email: data["$survey_response_2adad347-bc39-48f3-b5d1-755278685c94"] as string,

Or better yet, use a more readable field name for the email input.

🔍 Detailed Analysis

Code Quality & Best Practices: ⚠️ Moderate

• Code structure is clean and follows React patterns
• The fragile email access pattern reduces maintainability
• Consider extracting the survey field name to a constant

Potential Bugs: ❌ High Risk

• The .toArray() call will cause runtime errors
• Email access could fail silently if form structure changes

Performance: ✅ Good

• Minimal performance impact
• Object.values() creates unnecessary array but impact is negligible for this use case

Security: ✅ Good

• Email data being sent to PostHog is appropriate for analytics
• No sensitive information exposure risks
• Input validation handled by HTML5 email type

Test Coverage: ⚠️ Missing

• No tests for the new PostHog email setting functionality
• Consider adding tests to verify:
  • Email is correctly extracted from form data
  • PostHog setPersonProperties is called with correct email
  • Error handling if email extraction fails

🎯 Recommendations

1. Fix the critical bug by removing .toArray() from line 14
2. Improve email access by using direct field name instead of Object.values()[0]
3. Add tests for the new email setting functionality
4. Consider extracting the survey field name to a named constant for better maintainability

Overall: Good feature addition with some implementation issues that need addressing before merge.

[jog1t]

• feat(site): set user's email during newsletter form submission #2810 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Merge activity

• Jul 28, 7:02 PM UTC: jog1t added this pull request to the Graphite merge queue.
• Jul 28, 7:03 PM UTC: CI is running for this pull request on a draft pull request (#2811) due to your merge queue CI optimization settings.
• Jul 28, 7:04 PM UTC: Merged by the Graphite merge queue via draft PR: #2811.

[cloudflare-workers-and-pages]

Deploying rivet with    Cloudflare Pages

Latest commit:	1be0c0d
Status:	🚫  Build failed.

View logs

[graphite-app]

Graphite Automations

"Test" took an action on this PR • (07/28/25)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.