fix(inspector): use proper status indicator #2849
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
### TL;DR Fixed the disconnected state in the ConnectionStatus component to only display when there's an actual error. ### What changed? - Uncommented the `if (isError)` condition that was previously commented out - Moved the disconnected state UI inside the conditional block - Added the link icon as a `startIcon` prop to the Button component instead of as a child element ### How to test? 1. Intentionally cause a connection error in the application 2. Verify that the disconnected state UI only appears when there's an actual error 3. Check that the "Reconnect" button displays correctly with the link icon ### Why make this change? The disconnected state was previously always showing regardless of connection status because the conditional check was commented out. This change ensures the error UI only displays when there's an actual connection error, improving the user experience by providing accurate connection status information.
graphite-app
bot
deleted the
09-02-fix_inspector_use_proper_status_indicator
branch
Contributor
Graphite Automations"Test" took an action on this PR • (09/02/25)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixed the disconnected state in the ConnectionStatus component to only display when there's an actual error.
What changed?
if (isError)condition that was previously commented outstartIconprop to the Button component instead of as a child elementHow to test?
Why make this change?
The disconnected state was previously always showing regardless of connection status because the conditional check was commented out. This change ensures the error UI only displays when there's an actual connection error, improving the user experience by providing accurate connection status information.