-
Notifications
You must be signed in to change notification settings - Fork 134
Add Claude Code GitHub Workflow #3226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Code Review: Claude Code GitHub WorkflowThanks for setting up the Claude Code integration! This is a solid implementation that will enable AI-assisted development. Here's my review: ✅ Strengths
🔍 Code Quality & Best PracticesWorkflow Structure (.github/workflows/claude-code-review.yml:39-52)
Permissions (.github/workflows/claude.yml:26)
🐛 Potential Issues
🔒 Security Considerations
Recommendation: Consider documenting which users can trigger these workflows (currently anyone who can comment) ⚡ Performance Considerations
🧪 Test CoverageMissing: No tests for the workflow itself, but GitHub Actions workflows are typically tested in practice. Consider:
📝 Additional Recommendations
Required Changes# .github/workflows/claude-code-review.yml
permissions:
contents: read
pull-requests: write # Changed from 'read' - required for gh pr comment
issues: read
id-token: write
actions: read # Added for CI result contextSuggested Improvements# .github/workflows/claude-code-review.yml
on:
pull_request:
types: [opened, synchronize]
jobs:
claude-review:
# Skip draft PRs and those marked to skip review
if: |
github.event.pull_request.draft == false &&
!contains(github.event.pull_request.title, '[skip-review]')SummaryThis is a well-implemented integration that will be valuable for the team. The main blocker is the missing write permission for pull requests. Once that's fixed, this should work smoothly. Verdict: Approve with required fix for permissions ✅ Action Items:
Let me know if you'd like me to push these changes! |
🤖 Installing Claude Code GitHub App
This PR adds a GitHub Actions workflow that enables Claude Code integration in our repository.
What is Claude Code?
Claude Code is an AI coding agent that can help with:
How it works
Once this PR is merged, we'll be able to interact with Claude by mentioning @claude in a pull request or issue comment.
Once the workflow is triggered, Claude will analyze the comment and surrounding context, and execute on the request in a GitHub action.
Important Notes
Security
There's more information in the Claude Code action repo.
After merging this PR, let's try mentioning @claude in a comment on any PR to get started!