fix(fe): empty token it is a valid token

[jog1t]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-inspector	Ready	Preview	Comment	Oct 26, 2025 10:44pm

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-cloud	Ignored			Oct 26, 2025 10:44pm
rivet-site	Ignored	Preview		Oct 26, 2025 10:44pm

[jog1t]

• fix(fe): redirect engine users to connect page when there's no actors #3269 : 2 dependent PRs (#3270 , #3271 )
• fix(fe): empty token it is a valid token #3268 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: fix(fe): empty token it is a valid token

Summary

This PR removes the conditional check that prevented creating an actorContext when engineToken is falsy (including empty string). The change allows the actor inspector to function even when the engine token is an empty string.

Analysis

What Changed

Before:

• actorContext was only created if engineToken was truthy
• An empty string ("") would result in actorContext being null
• This triggered the error UI at line 274-290 about missing engine token

After:

• actorContext is always created, regardless of engineToken value
• The engineToken parameter (which can be undefined or "") is still passed to createInspectorActorContext

Why This Works

Looking at createInspectorActorContext in frontend/src/queries/actor-inspector.ts:30:

• engineToken is optional (engineToken?: string)
• It's conditionally added to headers: ...(engineToken ? { "x-rivet-token": engineToken } : {})
• An empty string is falsy, so the header is omitted when engineToken is ""
• This means passing an empty string has the same effect as passing undefined

Code Quality Assessment

✅ Positive:

1. Logic Simplification: Removes unnecessary conditional logic
2. Correct Behavior: Empty string is semantically valid when the token is optional
3. Proper Fallback: The downstream function handles missing tokens correctly
4. User Experience: Removes incorrect error message for valid scenarios

⚠️ Potential Concerns:

1. Unreachable Code: The null check at line 274 becomes unreachable after this change:

if (!actorContext) {
  // This will never execute now since actorContext is always created
  return (
    <InspectorGuardContext.Provider value={...}>
      ...
    </InspectorGuardContext.Provider>
  );
}

Recommendation: This dead code should be removed in a follow-up PR or this PR to keep the codebase clean.

2. Type Clarity: Consider making the return type explicit to indicate it never returns null:

const actorContext = useMemo((): ActorContext => {
  return createInspectorActorContext({...});
}, [...]);

Testing Considerations

• ✅ Verify actor inspector works with empty engine token
• ✅ Verify actor inspector still works with valid engine token
• ✅ Test both cloud and engine app types

Security Assessment

✅ No security concerns. The change properly handles optional authentication tokens.

Performance

✅ No performance impact. Minor improvement by removing unnecessary conditional.

Verdict

APPROVE with suggestion: The change is correct and improves the code. However, the dead code at lines 274-290 should be cleaned up since actorContext can never be null after this change.

---

Review generated with Claude Code

[pkg-pr-new]

More templates

• example-ai-agent
• example-background-jobs
• example-better-auth-external-db
• example-bots
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• example-counter
• example-counter-serverless
• example-crdt
• example-cursors
• example-cursors-raw-websocket
• example-database
• example-deno
• example-sqlite
• example-elysia
• example-express
• example-freestyle
• example-game
• example-hono
• example-hono-bun
• example-hono-react
• example-kitchen-sink
• example-next-js
• example-rate
• example-raw-fetch-handler
• example-raw-websocket-handler
• example-raw-websocket-handler-proxy
• example-react
• example-smoke-test
• starter
• example-stream
• example-sync
• example-tenant
• example-trpc
• example-workflows

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/actor@3268

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3268

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/core@3268

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3268

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3268

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3268

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3268

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3268

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3268

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3268

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3268

commit: b0b87b0

[graphite-app]

Graphite Automations

"Test" took an action on this PR • (10/26/25)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.