Skip to content

Conversation

@NicholasKissel
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Nov 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
rivet-site Ready Ready Preview Comment Nov 14, 2025 10:01pm
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
rivet-cloud Ignored Ignored Nov 14, 2025 10:01pm
rivet-inspector Ignored Ignored Preview Nov 14, 2025 10:01pm
rivetkit-serverless Skipped Skipped Nov 14, 2025 10:01pm

@vercel vercel bot temporarily deployed to Preview – rivetkit-serverless November 14, 2025 21:58 Inactive
Copy link
Member Author


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Nov 14, 2025

PR Review: Weekly Update 2025-46

Summary

This PR adds a weekly changelog post for week 2025-46 with updates about RivetKit features including JSON/CBOR support, OpenAPI/AsyncAPI specs, actor lifecycle improvements, and Cloudflare Workers enhancements.

✅ Positives

  • Clear and concise: The changelog items are well-written and easy to understand
  • Consistent format: Follows the established pattern from previous weekly updates
  • Good metadata: Appropriate keywords and category classification
  • Valid image: PNG image is properly formatted (2048x1024)

⚠️ Issues Found

1. Directory Naming Mismatch (Minor)

The directory is named 2025-11-09-weekly-updates but the published date is 2025-11-14.

Looking at previous weekly updates:

  • 2025-11-02-weekly-updates/ has published = "2025-11-02"
  • 2025-10-24-weekly-updates/ has published = "2025-10-24"

Recommendation: Either:

  • Rename directory to 2025-11-14-weekly-updates/, OR
  • Change published date to "2025-11-09"

The published date should match the directory name for consistency.

2. Title Format Inconsistency (Minor)

The title uses 2025-46 (ISO week number format), but some earlier posts use different formats:

  • Week 45: Rivet Weekly Changelog 2025-45
  • Week 43: Rivet Weekly Changelog 2025-43
  • Week 37: Rivet Weekly Changelog 2025.37 (note the period instead of dash)

Recommendation: Maintain consistency with recent posts by using the dash format 2025-46 (which you're already doing).

3. URL in Curl Example (Cosmetic)

Line 8: The curl example uses 127.1:6420 which might be confusing. Typically you'd see:

  • 127.0.0.1:6420 or
  • localhost:6420

Recommendation: Consider using localhost:6420 for clarity, though 127.1 is technically valid shorthand.

📝 Suggestions

  1. Links: The GitHub links use main branch - ensure these files exist on main before merging, or use commit hashes if they're in this PR or a dependent one.

  2. Documentation: Consider adding brief descriptions for technical items:

    • What is CBOR and why would users want it?
    • What use case does createInlineClient solve?

✅ No Issues Found With

  • Code Quality: N/A (no code changes)
  • Security: No security concerns with static content
  • Performance: N/A (static content)
  • Test Coverage: N/A (documentation update)

Verdict

LGTM with minor fixes recommended - The main issue is the directory/published date mismatch which should be resolved for consistency. Otherwise, this is a solid changelog update.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 14, 2025

Merge activity

  • Nov 14, 10:29 PM UTC: NicholasKissel added this pull request to the Graphite merge queue.
  • Nov 14, 10:29 PM UTC: CI is running for this pull request on a draft pull request (#3471) due to your merge queue CI optimization settings.
  • Nov 14, 10:30 PM UTC: Merged by the Graphite merge queue via draft PR: #3471.

graphite-app bot pushed a commit that referenced this pull request Nov 14, 2025
@graphite-app graphite-app bot closed this Nov 14, 2025
@graphite-app graphite-app bot deleted the 11-14-chore_weekly_update branch November 14, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants