Skip to content

chore: change streamingmode to exact for ranges with limits #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 11-17-fix_gas_optimize_loops
Choose a base branch
from
Draft

chore: change streamingmode to exact for ranges with limits #3476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/packages/epoxy/src/replica/messages/download_instances.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ pub async fn download_instances(
let range = RangeOption {
begin: begin_key,
end: end_key,
mode: StreamingMode::WantAll,
mode: StreamingMode::Exact,
limit: Some(req.count as usize),
..Default::default()
};
Expand Down
6 changes: 3 additions & 3 deletions engine/packages/epoxy/src/workflows/replica/setup.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,10 +443,10 @@ pub async fn recover_keys_chunk(

// Scan for key instances
let range_option = RangeOption {
begin: begin_key,
end: end_key,
mode: StreamingMode::Exact,
limit: Some(count as usize),
mode: StreamingMode::WantAll,
end: end_key,
begin: begin_key,
..Default::default()
};

Expand Down
4 changes: 2 additions & 2 deletions engine/packages/gasoline/src/db/kv/debug.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ impl DatabaseDebug for DatabaseKv {
async {
tx.get_ranges_keyvalues(
RangeOption {
mode: StreamingMode::WantAll,
mode: StreamingMode::Exact,
limit: Some(1),
..(&output_subspace).into()
},
Expand Down Expand Up @@ -670,7 +670,7 @@ impl DatabaseDebug for DatabaseKv {
async {
tx.get_ranges_keyvalues(
RangeOption {
mode: StreamingMode::WantAll,
mode: StreamingMode::Exact,
limit: Some(1),
..(&output_subspace).into()
},
Expand Down
2 changes: 1 addition & 1 deletion engine/packages/namespace/src/ops/runner_config/list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ pub async fn namespace_runner_config_list(

tx.get_ranges_keyvalues(
universaldb::RangeOption {
mode: StreamingMode::WantAll,
mode: StreamingMode::Exact,
limit: Some(input.limit),
..(start, end).into()
},
Expand Down
2 changes: 1 addition & 1 deletion engine/packages/pegboard/src/ops/actor/list_names.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ pub async fn pegboard_actor_list_names(ctx: &OperationCtx, input: &Input) -> Res

tx.get_ranges_keyvalues(
universaldb::RangeOption {
mode: StreamingMode::WantAll,
mode: StreamingMode::Exact,
limit: Some(input.limit),
..(start, end).into()
},
Expand Down
2 changes: 1 addition & 1 deletion engine/packages/pegboard/src/ops/runner/list_names.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ pub async fn pegboard_runner_list_names(ctx: &OperationCtx, input: &Input) -> Re

tx.get_ranges_keyvalues(
universaldb::RangeOption {
mode: StreamingMode::WantAll,
mode: StreamingMode::Exact,
limit: Some(input.limit),
..(start, end).into()
},
Expand Down
Loading