Skip to content

fix(pb): rewrite runner wf to handle batch signals #3480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 11-17-fix_gas_fix_batch_listen_fix_history_for_graceful_signal_send_in_workflows
Choose a base branch
from
+1,187 −10
Draft

fix(pb): rewrite runner wf to handle batch signals #3480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engine/packages/pegboard-runner/src/conn.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ pub async fn init_conn(
};

// Forward to runner wf
ctx.signal(pegboard::workflows::runner::Forward { inner: packet })
ctx.signal(pegboard::workflows::runner2::Forward { inner: packet })
.to_workflow_id(workflow_id)
.send()
.await
Expand Down
2 changes: 1 addition & 1 deletion engine/packages/pegboard-runner/src/ping_task.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ pub async fn task(
if let RunnerEligibility::ReEligible = notif.eligibility {
tracing::debug!(runner_id=?notif.runner_id, "runner has become eligible again");

ctx.signal(pegboard::workflows::runner::CheckQueue {})
ctx.signal(pegboard::workflows::runner2::CheckQueue {})
.to_workflow_id(notif.workflow_id)
.send()
.await?;
Expand Down
2 changes: 1 addition & 1 deletion engine/packages/pegboard-runner/src/ws_to_tunnel_task.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ async fn handle_message(
| protocol::ToServer::ToServerEvents(_)
| protocol::ToServer::ToServerAckCommands(_)
| protocol::ToServer::ToServerStopping => {
ctx.signal(pegboard::workflows::runner::Forward {
ctx.signal(pegboard::workflows::runner2::Forward {
inner: protocol::ToServer::try_from(msg)
.context("failed to convert message for workflow forwarding")?,
})
Expand Down
10 changes: 5 additions & 5 deletions engine/packages/pegboard/src/workflows/actor/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ pub async fn pegboard_actor(ctx: &mut WorkflowCtx, input: &Input) -> Result<()>
.await?;

// Send signal to stop actor now that we know it will be sleeping
ctx.signal(crate::workflows::runner::Command {
ctx.signal(crate::workflows::runner2::Command {
inner: protocol::Command::CommandStopActor(
protocol::CommandStopActor {
actor_id: input.actor_id.to_string(),
Expand Down Expand Up @@ -348,7 +348,7 @@ pub async fn pegboard_actor(ctx: &mut WorkflowCtx, input: &Input) -> Result<()>
})
.await?;

ctx.signal(crate::workflows::runner::Command {
ctx.signal(crate::workflows::runner2::Command {
inner: protocol::Command::CommandStopActor(
protocol::CommandStopActor {
actor_id: input.actor_id.to_string(),
Expand Down Expand Up @@ -495,7 +495,7 @@ pub async fn pegboard_actor(ctx: &mut WorkflowCtx, input: &Input) -> Result<()>
})
.await?;

ctx.signal(crate::workflows::runner::Command {
ctx.signal(crate::workflows::runner2::Command {
inner: protocol::Command::CommandStopActor(protocol::CommandStopActor {
actor_id: input.actor_id.to_string(),
generation: state.generation,
Expand All @@ -509,7 +509,7 @@ pub async fn pegboard_actor(ctx: &mut WorkflowCtx, input: &Input) -> Result<()>
Main::Destroy(_) => {
// If allocated, send stop actor command
if let Some(runner_workflow_id) = state.runner_workflow_id {
ctx.signal(crate::workflows::runner::Command {
ctx.signal(crate::workflows::runner2::Command {
inner: protocol::Command::CommandStopActor(protocol::CommandStopActor {
actor_id: input.actor_id.to_string(),
generation: state.generation,
Expand Down Expand Up @@ -628,7 +628,7 @@ async fn handle_stopped(
if let (StoppedVariant::Lost { .. }, Some(old_runner_workflow_id)) =
(&variant, old_runner_workflow_id)
{
ctx.signal(crate::workflows::runner::Command {
ctx.signal(crate::workflows::runner2::Command {
inner: protocol::Command::CommandStopActor(protocol::CommandStopActor {
actor_id: input.actor_id.to_string(),
generation: state.generation,
Expand Down
4 changes: 2 additions & 2 deletions engine/packages/pegboard/src/workflows/actor/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ pub async fn spawn_actor(
.send()
.await?;

ctx.signal(crate::workflows::runner::Command {
ctx.signal(crate::workflows::runner2::Command {
inner: protocol::Command::CommandStartActor(protocol::CommandStartActor {
actor_id: input.actor_id.to_string(),
generation,
Expand Down Expand Up @@ -563,7 +563,7 @@ pub async fn spawn_actor(
})
.await?;

ctx.signal(crate::workflows::runner::Command {
ctx.signal(crate::workflows::runner2::Command {
inner: protocol::Command::CommandStartActor(protocol::CommandStartActor {
actor_id: input.actor_id.to_string(),
generation,
Expand Down
1 change: 1 addition & 0 deletions engine/packages/pegboard/src/workflows/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
pub mod actor;
pub mod runner;
pub mod runner2;
Loading
Loading