Skip to content

fix(pegboard): fix actors getting destroyed on runner shutdown #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(pegboard): fix actors getting destroyed on runner shutdown #3499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions engine/packages/pegboard/src/workflows/actor/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,8 +666,8 @@ async fn handle_stopped(
}
);

match (input.crash_policy, failed) {
(CrashPolicy::Restart, true) => {
match input.crash_policy {
CrashPolicy::Restart => {
match runtime::reschedule_actor(ctx, &input, state, false).await? {
runtime::SpawnActorOutput::Allocated { .. } => {}
// NOTE: Its not possible for `SpawnActorOutput::Sleep` to be returned here, the crash
Expand All @@ -678,8 +678,12 @@ async fn handle_stopped(
}
}
}
(CrashPolicy::Sleep, true) => {
tracing::debug!(actor_id=?input.actor_id, "actor sleeping due to crash");
CrashPolicy::Sleep => {
if failed {
tracing::debug!(actor_id=?input.actor_id, "actor sleeping due to crash");
} else {
tracing::debug!(actor_id=?input.actor_id, "actor sleeping due to clean shutdown");
}

state.sleeping = true;

Expand Down
Loading