-
Notifications
You must be signed in to change notification settings - Fork 135
fix(cloud): incorrect property names for railway #3531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloud): incorrect property names for railway #3531
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
### TL;DR Updated Rivet environment variable names by removing the `NEXT_PUBLIC_` prefix. ### What changed? Modified the environment variable keys displayed in the Railway connection dialog: - Changed `NEXT_PUBLIC_RIVET_RUNNER` to `RIVET_RUNNER` - Changed `NEXT_PUBLIC_RIVET_TOKEN` to `RIVET_TOKEN` - Changed `NEXT_PUBLIC_RIVET_ENDPOINT` to `RIVET_ENDPOINT` - Changed `NEXT_PUBLIC_RIVET_NAMESPACE` to `RIVET_NAMESPACE` ### How to test? 1. Open the Railway connection dialog 2. Verify that the environment variable keys are displayed without the `NEXT_PUBLIC_` prefix 3. Ensure that the connection functionality still works correctly with the updated variable names ### Why make this change? The `NEXT_PUBLIC_` prefix is typically used for client-side environment variables in Next.js applications. Since these Rivet variables are likely meant to be server-side only, removing this prefix ensures they won't be exposed to the client, improving security and following best practices for environment variable naming.
Graphite Automations"Test" took an action on this PR • (11/23/25)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
PR Review: fix(cloud): incorrect property names for railwaySummaryThis PR correctly updates the environment variable names displayed in the Railway connection dialog, removing the ✅ Code QualityThe changes are straightforward and focused - simple string value replacements with no logic changes. The code follows existing patterns in the file. ✅ Correctness VerifiedI verified these environment variable names against the RivetKit SDK source code:
endpoint: z.string().optional().transform(
(x) => x ?? getEnvUniversal("RIVET_ENGINE") ?? getEnvUniversal("RIVET_ENDPOINT"),
),
token: z.string().optional().transform((x) => x ?? getEnvUniversal("RIVET_TOKEN")),
namespace: z.string().default(() => getEnvUniversal("RIVET_NAMESPACE") ?? "default"),
runnerName: z.string().default(() => getEnvUniversal("RIVET_RUNNER") ?? "default"),The new values ( ✅ SecurityThe PR description is accurate - removing the ✅ Documentation ConsistencyThe documentation in
|

TL;DR
Updated Rivet environment variable names by removing the
NEXT_PUBLIC_prefix.What changed?
Modified the environment variable keys displayed in the Railway connection dialog:
NEXT_PUBLIC_RIVET_RUNNERtoRIVET_RUNNERNEXT_PUBLIC_RIVET_TOKENtoRIVET_TOKENNEXT_PUBLIC_RIVET_ENDPOINTtoRIVET_ENDPOINTNEXT_PUBLIC_RIVET_NAMESPACEtoRIVET_NAMESPACEHow to test?
NEXT_PUBLIC_prefixWhy make this change?
The
NEXT_PUBLIC_prefix is typically used for client-side environment variables in Next.js applications. Since these Rivet variables are likely meant to be server-side only, removing this prefix ensures they won't be exposed to the client, improving security and following best practices for environment variable naming.