Skip to content

fix!: Cleanup API definitions, module imports #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2024
Merged

fix!: Cleanup API definitions, module imports #534

merged 1 commit into from
May 18, 2024

Conversation

@MasterPtato
Copy link
Contributor

@MasterPtato MasterPtato commented Feb 23, 2024 •
edited
Loading

Changes

  • Breaking change caused by updating the route from cloud.games.games to cloud.games in the Fern API

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 23, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented Feb 23, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on Graphite Graphite

This was referenced Feb 23, 2024
Merged
Merged
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from 2b16e85 to a806eb2 Compare February 23, 2024 01:24
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from a806eb2 to 6740d18 Compare February 27, 2024 21:51
@MasterPtato MasterPtato force-pushed the 02-23-Cleanup branch 3 times, most recently from 5a85e02 to bc96360 Compare February 28, 2024 01:13
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from 6740d18 to 3b63544 Compare February 28, 2024 17:50
@MasterPtato MasterPtato force-pushed the 02-23-Cleanup branch 2 times, most recently from e4dbf22 to d980ffa Compare February 28, 2024 21:05
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from 3b63544 to f2a7104 Compare March 1, 2024 01:31
@MasterPtato MasterPtato changed the title Cleanup fix: Cleanup API definitions Mar 6, 2024
@MasterPtato MasterPtato changed the title fix: Cleanup API definitions fix: Cleanup API definitions, module imports Mar 6, 2024
@MasterPtato MasterPtato marked this pull request as ready for review March 6, 2024 00:55
@MasterPtato MasterPtato changed the title fix: Cleanup API definitions, module imports fix!: Cleanup API definitions, module imports Mar 6, 2024
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from f2a7104 to 92b7f75 Compare March 15, 2024 19:36
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from 92b7f75 to 4440b0e Compare March 15, 2024 20:09
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from 4440b0e to 9fc24a3 Compare April 3, 2024 18:14
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from 9fc24a3 to bc2ec9d Compare April 4, 2024 17:39
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from 3d668fd to bb3b02c Compare April 24, 2024 18:47
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from bb3b02c to 5f2f32f Compare April 25, 2024 18:39
@MasterPtato MasterPtato mentioned this pull request Apr 25, 2024
Merged
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from 5f2f32f to 02773c1 Compare May 2, 2024 19:13
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from 02773c1 to c482a5c Compare May 6, 2024 21:29
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from c482a5c to bfa2d14 Compare May 10, 2024 23:54
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from bfa2d14 to a3c3e38 Compare May 16, 2024 22:30
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from a3c3e38 to 6656b6c Compare May 17, 2024 20:27
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from 6656b6c to 4180a7d Compare May 17, 2024 20:58
@MasterPtato MasterPtato force-pushed the 02-22-Remove_old_module_code branch from 50d2ca7 to 689d203 Compare May 17, 2024 23:58
@MasterPtato MasterPtato changed the base branch from 02-22-Remove_old_module_code to main May 18, 2024 00:01
@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented May 18, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • May 17, 8:01 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • May 17, 8:03 PM EDT: MasterPtato added this pull request to the Graphite merge queue.
  • May 17, 8:16 PM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • May 17, 9:05 PM EDT: MasterPtato added this pull request to the Graphite merge queue.
  • May 17, 9:15 PM EDT: MasterPtato merged this pull request with the Graphite merge queue.

@MasterPtato MasterPtato mentioned this pull request May 18, 2024
Merged
@MasterPtato
fix!: Cleanup API definitions, module imports (#534)
0e0660a 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes
- Breaking change caused by updating the route from cloud.games.games to cloud.games in the Fern API
<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot merged commit 0e0660a into main May 18, 2024
@graphite-app graphite-app bot deleted the 02-23-Cleanup branch May 18, 2024 01:15
@github-actions github-actions bot mentioned this pull request May 18, 2024
Merged
@MasterPtato MasterPtato mentioned this pull request May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanFlurry NathanFlurry NathanFlurry approved these changes

+1 more reviewer

@AngelOnFira AngelOnFira AngelOnFira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MasterPtato @NathanFlurry @AngelOnFira