Skip to content

Conversation

@AngelOnFira
Copy link
Contributor

@AngelOnFira AngelOnFira commented Apr 25, 2024

This might cause some issues with existing files created with vscode (say when using the GUI Git to do certain things). But it's better that it's off root, since most of the time the host won't be root.

Copy link
Contributor Author

AngelOnFira commented Apr 25, 2024

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 25, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@AngelOnFira AngelOnFira changed the base branch from main to 04-25-fix_move_grafana_to_its_own_helm_chart April 25, 2024 23:55
@AngelOnFira AngelOnFira force-pushed the 04-25-chore_change_devcontainer_user_off_root branch from cbf073e to 9da5942 Compare April 25, 2024 23:55
@MasterPtato MasterPtato force-pushed the 04-25-fix_move_grafana_to_its_own_helm_chart branch 2 times, most recently from 2e01987 to e4474b6 Compare April 26, 2024 00:40
@AngelOnFira AngelOnFira force-pushed the 04-25-chore_change_devcontainer_user_off_root branch from 9da5942 to b9a0f7f Compare April 26, 2024 00:41
@MasterPtato MasterPtato force-pushed the 04-25-fix_move_grafana_to_its_own_helm_chart branch from e4474b6 to 6799cdc Compare April 26, 2024 00:47
@AngelOnFira AngelOnFira force-pushed the 04-25-chore_change_devcontainer_user_off_root branch from b9a0f7f to 5cb48e3 Compare April 26, 2024 19:50
@AngelOnFira AngelOnFira changed the base branch from 04-25-fix_move_grafana_to_its_own_helm_chart to 04-29-fix_change_test_relative_path April 29, 2024 23:04
@AngelOnFira AngelOnFira force-pushed the 04-25-chore_change_devcontainer_user_off_root branch from 5cb48e3 to 1f7e5f4 Compare April 29, 2024 23:04
@AngelOnFira AngelOnFira force-pushed the 04-29-fix_change_test_relative_path branch from b6ac782 to 30b0af5 Compare May 1, 2024 21:31
@AngelOnFira AngelOnFira force-pushed the 04-25-chore_change_devcontainer_user_off_root branch from 1f7e5f4 to b80b5a0 Compare May 1, 2024 21:31
@AngelOnFira AngelOnFira marked this pull request as ready for review May 1, 2024 21:34
@graphite-app
Copy link
Contributor

graphite-app bot commented May 2, 2024

Merge activity

@NathanFlurry NathanFlurry force-pushed the 04-29-fix_change_test_relative_path branch from 30b0af5 to daf1d07 Compare May 2, 2024 07:37
NathanFlurry pushed a commit that referenced this pull request May 2, 2024
This might cause some issues with existing files created with vscode (say when using the GUI Git to do certain things). But it's better that it's off root, since most of the time the host won't be root.
@NathanFlurry NathanFlurry force-pushed the 04-25-chore_change_devcontainer_user_off_root branch from b80b5a0 to 1b06fe8 Compare May 2, 2024 07:37
@NathanFlurry NathanFlurry changed the base branch from 04-29-fix_change_test_relative_path to main May 2, 2024 07:51
This might cause some issues with existing files created with vscode (say when using the GUI Git to do certain things). But it's better that it's off root, since most of the time the host won't be root.
@NathanFlurry NathanFlurry force-pushed the 04-25-chore_change_devcontainer_user_off_root branch from 1b06fe8 to af3566a Compare May 2, 2024 07:53
@graphite-app graphite-app bot merged commit af3566a into main May 2, 2024
@graphite-app graphite-app bot deleted the 04-25-chore_change_devcontainer_user_off_root branch May 2, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants