Skip to content

fix(grafana): fix circular dependency between grafana <-> cockroachdb_managed #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2024
Merged

fix(grafana): fix circular dependency between grafana <-> cockroachdb_managed #760

merged 1 commit into from
May 15, 2024

Conversation

@NathanFlurry
Copy link
Member

@NathanFlurry NathanFlurry commented May 2, 2024

Changes

@NathanFlurry NathanFlurry requested a review from MasterPtato May 2, 2024 04:20
@graphite-app
Copy link
Contributor

graphite-app bot commented May 2, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented May 2, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on Graphite Graphite

@NathanFlurry NathanFlurry force-pushed the 05-02-fix_grafana_fix_circular_dependency_between_grafana_-_cockroachdb_managed branch from a6a1e50 to 9c02457 Compare May 4, 2024 20:23
@NathanFlurry NathanFlurry requested a review from MasterPtato May 4, 2024 20:23
This was referenced May 4, 2024
Merged
Merged
Merged
Merged
Merged
Closed
@NathanFlurry NathanFlurry changed the base branch from main to 05-04-fix_leaked_dns_records May 4, 2024 20:27
@NathanFlurry NathanFlurry force-pushed the 05-02-fix_grafana_fix_circular_dependency_between_grafana_-_cockroachdb_managed branch from 9c02457 to c20f58b Compare May 4, 2024 20:27
@MasterPtato MasterPtato mentioned this pull request May 4, 2024
Merged
This was referenced May 4, 2024
Merged
Merged
@MasterPtato MasterPtato force-pushed the 05-04-fix_leaked_dns_records branch from 8ba973a to d1421f9 Compare May 4, 2024 21:32
This was referenced May 4, 2024
Merged
Merged
@NathanFlurry NathanFlurry changed the base branch from 05-04-fix_leaked_dns_records to 05-04-fix_taint_logic_for_job_nodes_with_no_nomad_node May 5, 2024 00:06
@NathanFlurry NathanFlurry force-pushed the 05-02-fix_grafana_fix_circular_dependency_between_grafana_-_cockroachdb_managed branch from c20f58b to 024bf73 Compare May 5, 2024 00:06
@graphite-app
Copy link
Contributor

graphite-app bot commented May 15, 2024 •
edited
Loading

Merge activity

@NathanFlurry
fix(grafana): fix circular dependency between grafana <-> cockroachdb…
46e3bf0 
…_managed (#760)

<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@NathanFlurry NathanFlurry force-pushed the 05-04-fix_taint_logic_for_job_nodes_with_no_nomad_node branch from 3769c26 to 97f6b72 Compare May 15, 2024 00:38
@NathanFlurry NathanFlurry force-pushed the 05-02-fix_grafana_fix_circular_dependency_between_grafana_-_cockroachdb_managed branch from 024bf73 to 46e3bf0 Compare May 15, 2024 00:38
@NathanFlurry NathanFlurry changed the base branch from 05-04-fix_taint_logic_for_job_nodes_with_no_nomad_node to main May 15, 2024 01:01
@graphite-app graphite-app bot merged commit 46e3bf0 into main May 15, 2024
@graphite-app graphite-app bot deleted the 05-02-fix_grafana_fix_circular_dependency_between_grafana_-_cockroachdb_managed branch May 15, 2024 01:06
@github-actions github-actions bot mentioned this pull request May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasterPtato MasterPtato MasterPtato approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NathanFlurry @MasterPtato