Skip to content

fix(job-run): fix leaking jobs with wrong param order #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2024
Merged

fix(job-run): fix leaking jobs with wrong param order #815

merged 1 commit into from
May 31, 2024

Conversation

@NathanFlurry
Copy link
Member

@NathanFlurry NathanFlurry commented May 29, 2024

Changes

@NathanFlurry NathanFlurry requested a review from MasterPtato May 29, 2024 02:41
@graphite-app
Copy link
Contributor

graphite-app bot commented May 29, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

This was referenced May 29, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented May 29, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on Graphite Graphite

This was referenced May 29, 2024
Merged
Merged
@NathanFlurry NathanFlurry force-pushed the 05-28-fix_cluter_disable_prebake_images branch from 5a119f2 to f9e06c8 Compare May 29, 2024 03:08
@NathanFlurry NathanFlurry force-pushed the 05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order branch from 02c9680 to d572b8b Compare May 29, 2024 03:08
@NathanFlurry NathanFlurry mentioned this pull request May 29, 2024
Merged
@NathanFlurry NathanFlurry force-pushed the 05-28-fix_cluter_disable_prebake_images branch from f9e06c8 to 56701b6 Compare May 29, 2024 18:29
@NathanFlurry NathanFlurry force-pushed the 05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order branch from d572b8b to 7d8b3ad Compare May 29, 2024 18:29
This was referenced May 29, 2024
Merged
Merged
Merged
This was referenced May 30, 2024
Merged
Merged
This was referenced May 30, 2024
Merged
Merged
Merged
Merged
Merged
@NathanFlurry NathanFlurry force-pushed the 05-28-fix_cluter_disable_prebake_images branch from 56701b6 to fd5ccdb Compare May 31, 2024 00:42
@NathanFlurry NathanFlurry force-pushed the 05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order branch from 7d8b3ad to 41ae17b Compare May 31, 2024 00:42
@MasterPtato MasterPtato mentioned this pull request May 31, 2024
Merged
@NathanFlurry NathanFlurry mentioned this pull request May 31, 2024
Merged
@MasterPtato MasterPtato force-pushed the 05-28-fix_cluter_disable_prebake_images branch from fd5ccdb to a1bff9f Compare May 31, 2024 19:41
@MasterPtato MasterPtato force-pushed the 05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order branch from 41ae17b to 6ead484 Compare May 31, 2024 19:41
@MasterPtato MasterPtato mentioned this pull request May 31, 2024
Merged
@MasterPtato MasterPtato force-pushed the 05-28-fix_cluter_disable_prebake_images branch from a1bff9f to 23a9e00 Compare May 31, 2024 19:48
@MasterPtato MasterPtato force-pushed the 05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order branch from 6ead484 to 7ee05b8 Compare May 31, 2024 19:48
This was referenced May 31, 2024
Merged
Merged
@graphite-app
Copy link
Contributor

graphite-app bot commented May 31, 2024 •
edited
Loading

Merge activity

@NathanFlurry NathanFlurry force-pushed the 05-28-fix_cluter_disable_prebake_images branch from 23a9e00 to 003500a Compare May 31, 2024 21:33
NathanFlurry added a commit that referenced this pull request May 31, 2024
@NathanFlurry
fix(job-run): fix leaking jobs with wrong param order (#815)
c52517b 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@NathanFlurry NathanFlurry force-pushed the 05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order branch from 7ee05b8 to c52517b Compare May 31, 2024 21:33
@NathanFlurry
fix(job-run): fix leaking jobs with wrong param order (#815)
6350c72 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@NathanFlurry NathanFlurry force-pushed the 05-28-fix_cluter_disable_prebake_images branch from 003500a to cdb6133 Compare May 31, 2024 22:05
@NathanFlurry NathanFlurry force-pushed the 05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order branch from c52517b to 6350c72 Compare May 31, 2024 22:06
@MasterPtato MasterPtato mentioned this pull request May 31, 2024
Merged
@NathanFlurry NathanFlurry changed the base branch from 05-28-fix_cluter_disable_prebake_images to main May 31, 2024 22:45
@graphite-app graphite-app bot merged commit 6350c72 into main May 31, 2024
@graphite-app graphite-app bot deleted the 05-29-fix_job-run_fix_leaking_jobs_with_wrong_param_order branch May 31, 2024 22:46
@github-actions github-actions bot mentioned this pull request May 31, 2024
Merged
This was referenced May 31, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MasterPtato MasterPtato MasterPtato approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NathanFlurry @MasterPtato