fix(mm): require specifying matchmaker config for new game versions #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Your org requires the Graphite merge queue for merging into mainYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NathanFlurry and the rest of your teammates on |
AngelOnFira
approved these changes
Jun 6, 2024
Contributor
Merge activity
|
…895) This fixes both: - accidental `rivet deploy` with unconfigured rivet.yaml (which submits an empty object) - we don't handle unconfigured matchmaker correctly
NathanFlurry
force-pushed
the
06-06-fix_mm_require_specifying_matchmaker_config_for_new_game_versions
branch
from
0d5fe9c to
92d86fd
Compare
graphite-app
bot
deleted the
06-06-fix_mm_require_specifying_matchmaker_config_for_new_game_versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes both:
rivet deploywith unconfigured rivet.yaml (which submits an empty object)