Skip to content

fix(mm): clean up players from gc zset #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2024
Merged

fix(mm): clean up players from gc zset #914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion svc/pkg/mm/worker/src/workers/player_remove.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,23 @@ async fn worker(ctx: &OperationContext<mm::msg::player_remove::Message>) -> Glob
tracing::error!("discarding stale message");
return Ok(());
} else {
retry_bail!("player not found, may be race condition with insertion");
// Delete what we can. Remove from GC so this message doesn't get published again.
tracing::warn!(
?player_id,
"player not found in sql or redis, cleaning up & discarding message"
);
let player_id_str = player_id.to_string();
redis::pipe()
.del(util_mm::key::player_config(player_id))
.ignore()
.zrem(util_mm::key::player_unregistered(), &player_id_str)
.ignore()
.zrem(util_mm::key::player_auto_remove(), &player_id_str)
.ignore()
.query_async(&mut ctx.redis_mm().await?)
.await?;

return Ok(());
};

// Validate lobby
Expand Down