Skip to content

fix(clusters): continue provisioning a server even when marked for deletion #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix(clusters): continue provisioning a server even when marked for deletion #924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions svc/pkg/cluster/worker/src/workers/server_provision.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ async fn inner(

// Check if server is already provisioned
// NOTE: sql record already exists before this worker is called
let (provider_server_id, destroyed) = sql_fetch_one!(
[ctx, (Option<String>, bool)]
let (provider_server_id,) = sql_fetch_one!(
[ctx, (Option<String>,)]
"
SELECT
provider_server_id, cloud_destroy_ts IS NOT NULL
provider_server_id
FROM db_cluster.servers
WHERE server_id = $1
",
Expand All @@ -54,10 +54,6 @@ async fn inner(
);
return Ok(());
}
if destroyed {
tracing::warn!(?server_id, "attempting to provision a destroyed server");
return Ok(());
}

// Fetch datacenter config
let datacenter_res = op!([ctx] cluster_datacenter_get {
Expand Down