Skip to content

chore(k3d): disable volumes if using use_local_repo #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2024
Merged

chore(k3d): disable volumes if using use_local_repo #954

merged 1 commit into from
Jul 3, 2024

Conversation

@NathanFlurry
Copy link
Member

@NathanFlurry NathanFlurry commented Jun 26, 2024

Changes

@NathanFlurry NathanFlurry requested a review from MasterPtato June 26, 2024 21:46
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 26, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Jun 26, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on Graphite Graphite

This was referenced Jun 26, 2024
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Closed
Closed
MasterPtato
MasterPtato requested changes Jun 27, 2024
View reviewed changes
lib/bolt/core/src/dep/terraform/gen.rs Outdated
Comment on lines 276 to 278
if let ns::KubernetesProvider::K3d { use_local_repo } = &config.kubernetes.provider {
vars.insert("k3d_use_local_repo".into(), json!(use_local_repo));
}
Copy link
Contributor

@MasterPtato MasterPtato Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also insert the var with value false if use_local_repo isn't set? The var in terraform isnt marked as optional

@NathanFlurry NathanFlurry force-pushed the 06-26-chore_k3d_disable_volumes_if_using_use_local_repo branch from 9dd22c2 to 4fb7920 Compare July 2, 2024 22:28
@NathanFlurry NathanFlurry requested a review from MasterPtato July 2, 2024 22:29
This was referenced Jul 2, 2024
Merged
Merged
@NathanFlurry NathanFlurry requested a review from AngelOnFira July 3, 2024 01:57
@NathanFlurry NathanFlurry mentioned this pull request Jul 3, 2024
Merged
@NathanFlurry NathanFlurry requested a review from MasterPtato July 3, 2024 05:57
This was referenced Jul 3, 2024
Merged
Merged
Merged
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 3, 2024 •
edited
Loading

Merge activity

@NathanFlurry
chore(k3d): disable volumes if using use_local_repo (#954)
c375325 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@NathanFlurry NathanFlurry force-pushed the 06-26-chore_k3d_disable_volumes_if_using_use_local_repo branch from 4fb7920 to c375325 Compare July 3, 2024 08:44
@graphite-app graphite-app bot merged commit c375325 into main Jul 3, 2024
@graphite-app graphite-app bot deleted the 06-26-chore_k3d_disable_volumes_if_using_use_local_repo branch July 3, 2024 08:49
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
Merged
This was referenced Jul 3, 2024
Merged
Merged
@NathanFlurry NathanFlurry mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AngelOnFira AngelOnFira Awaiting requested review from AngelOnFira

@MasterPtato MasterPtato Awaiting requested review from MasterPtato

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NathanFlurry @MasterPtato